Merge transcription sound toggle into picker with None option#168
Merged
altic-dev merged 2 commits intoaltic-dev:mainfrom Feb 23, 2026
Merged
Merge transcription sound toggle into picker with None option#168altic-dev merged 2 commits intoaltic-dev:mainfrom
altic-dev merged 2 commits intoaltic-dev:mainfrom
Conversation
moogman
force-pushed
the
b/merge-sound-toggle
branch
from
52edfc9 to
d23aa9f
Compare
Owner
|
Good one! if you can rebase to main as I've merged my earlier PR for 1.5.8, we can bring this onto 1.5.9 :) Thanks for catching this! |
Contributor
Author
|
Done :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies the Transcription Sounds settings by removing the separate on/off toggle and using a single sound picker that includes None to disable playback.
Type of Change
Related Issues
Closes #(issue number)
Testing
brew install swiftlint && swiftlint --strict --config .swiftlint.ymlbrew install swiftformat && swiftformat --config .swiftformat SourcesScreenshots / Video
Add screenshots or Video recording of the app after you have made your changes
