Open
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough앱 파일 업로드/사전서명 URL 조회/삭제, 워크스페이스 생성, 매니저용 워크스페이스 사유 댓글 CRUD 흐름이 추가되었습니다. 관련 DTO, 엔티티, 리포지토리, 인바운드/아웃바운드 포트 및 서비스(유스케이스)가 구현되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AppFileController
participant AppUploadFile
participant FileUploadService
participant FileRepository
Client->>AppFileController: POST /app/files (file, targetType, bucketType)
AppFileController->>AppFileController: AppActionContext.getActor()
AppFileController->>AppUploadFile: execute(actor, file, targetType, bucketType)
AppUploadFile->>FileUploadService: upload(userId, targetType, bucketType, file)
FileUploadService->>FileRepository: save metadata
FileRepository-->>FileUploadService: fileId
FileUploadService-->>AppUploadFile: fileId
AppUploadFile-->>AppFileController: AppUploadFileResponseDto(fileId)
AppFileController-->>Client: 200 OK (fileId)
sequenceDiagram
participant Client
participant UserWorkspaceController
participant CreateWorkspace
participant ManagerUserRepository
participant WorkspaceRepository
participant AttachFiles
Client->>UserWorkspaceController: POST /app/workspaces (CreateWorkspaceRequestDto)
UserWorkspaceController->>UserWorkspaceController: AppActionContext.getActor()
UserWorkspaceController->>CreateWorkspace: execute(actor, request)
CreateWorkspace->>ManagerUserRepository: save(managerUser)
ManagerUserRepository-->>CreateWorkspace: saved ManagerUser
CreateWorkspace->>WorkspaceRepository: save(workspace)
WorkspaceRepository-->>CreateWorkspace: workspaceId
CreateWorkspace->>AttachFiles: executeMap(fileIdsMap, workspaceId, userId)
AttachFiles-->>CreateWorkspace: void
CreateWorkspace-->>UserWorkspaceController: void
UserWorkspaceController-->>Client: 200 OK
sequenceDiagram
participant Client
participant ManagerController
participant CreateWorkspaceReasonComment
participant WorkspaceQueryRepository
participant WorkspaceReasonQueryRepository
participant CommentRepository
Client->>ManagerController: POST /manager/workspaces/{wId}/reasons/{rId}/comments (request)
ManagerController->>ManagerController: ManagerActionContext.getActor()
ManagerController->>CreateWorkspaceReasonComment: execute(actor, wId, rId, request)
CreateWorkspaceReasonComment->>WorkspaceQueryRepository: existsByIdAndManagerUser(wId, managerUserId)
WorkspaceQueryRepository-->>CreateWorkspaceReasonComment: boolean
CreateWorkspaceReasonComment->>WorkspaceReasonQueryRepository: findByIdAndWorkspaceId(rId, wId)
WorkspaceReasonQueryRepository-->>CreateWorkspaceReasonComment: WorkspaceReason?
CreateWorkspaceReasonComment->>CommentRepository: save(comment)
CommentRepository-->>CreateWorkspaceReasonComment: void
CreateWorkspaceReasonComment-->>ManagerController: void
ManagerController-->>Client: 200 OK
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 17
♻️ Duplicate comments (1)
src/main/java/com/dreamteam/alter/adapter/inbound/general/file/controller/AppFileController.java (1)
33-40:⚠️ Potential issue | 🟠 Major
@Resource와final필드 조합 문제가 반복됩니다.
UserWorkspaceController와 동일한 문제입니다.@Resource는 필드/세터 주입용이며final필드와@RequiredArgsConstructor와 함께 사용할 수 없습니다.♻️ 수정 제안
- `@Resource`(name = "appUploadFile") - private final AppUploadFileUseCase appUploadFile; + private final AppUploadFileUseCase appUploadFile; - `@Resource`(name = "appGetPresignedUrl") - private final AppGetPresignedUrlUseCase appGetPresignedUrl; + private final AppGetPresignedUrlUseCase appGetPresignedUrl; - `@Resource`(name = "appDeleteFile") - private final AppDeleteFileUseCase appDeleteFile; + private final AppDeleteFileUseCase appDeleteFile;생성자에서
@Qualifier사용이 필요한 경우:public AppFileController( `@Qualifier`("appUploadFile") AppUploadFileUseCase appUploadFile, `@Qualifier`("appGetPresignedUrl") AppGetPresignedUrlUseCase appGetPresignedUrl, `@Qualifier`("appDeleteFile") AppDeleteFileUseCase appDeleteFile ) { this.appUploadFile = appUploadFile; this.appGetPresignedUrl = appGetPresignedUrl; this.appDeleteFile = appDeleteFile; }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/com/dreamteam/alter/adapter/inbound/general/file/controller/AppFileController.java` around lines 33 - 40, The fields appUploadFile, appGetPresignedUrl, and appDeleteFile in AppFileController are annotated with `@Resource` while declared final, which conflicts with constructor-based injection; remove the `@Resource` annotations from those fields and add a constructor for AppFileController that accepts the three use-case parameters and assigns them to the final fields, applying `@Qualifier`("appUploadFile"), `@Qualifier`("appGetPresignedUrl"), and `@Qualifier`("appDeleteFile") to the corresponding constructor parameters to preserve bean selection.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/main/java/com/dreamteam/alter/adapter/inbound/general/workspace/controller/UserWorkspaceController.java`:
- Around line 26-27: The field injection on UserWorkspaceController uses
`@Resource` on a final field createWorkspace which prevents Spring from injecting
the dependency; change to constructor injection by adding a constructor that
takes CreateWorkspaceUseCase (or annotate the constructor parameter with
`@Qualifier`("createWorkspace")) and assign it to the createWorkspace field, or
remove final and use a non-final setter with `@Resource`—prefer constructor
injection for the CreateWorkspaceUseCase dependency to ensure proper wiring.
In
`@src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.java`:
- Around line 34-38: In ManagerWorkspaceReasonCommentController, remove the
field-level `@Resource` annotations on the final fields
createWorkspaceReasonComment and getWorkspaceReasonComments because
`@RequiredArgsConstructor` already generates constructor injection; if you need to
bind specific bean names, replace `@Resource` with `@Qualifier` qualifiers on those
dependencies (either annotate the fields with `@Qualifier`("beanName") or annotate
the constructor parameters), keeping the fields final and relying on Lombok's
`@RequiredArgsConstructor` for constructor injection.
In
`@src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentControllerSpec.java`:
- Around line 26-30: 메서드 이름 createWorkspaceReason이 실제로는 "사유 코멘트"를 생성하므로
인터페이스/컨트롤러 및 관련 구현 및 테스트에서 메서드명을 createWorkspaceReasonComment로 변경하세요; 구체적으로
ManagerWorkspaceReasonCommentControllerSpec 및 해당 인터페이스의 메서드 선언
ResponseEntity<CommonApiResponse<Void>> createWorkspaceReason(...) 를 찾아 이름을
createWorkspaceReasonComment(...)로 바꾸고, 이 메서드를 호출하거나 오버라이드하는 모든 구현체, 단위/통합 테스트,
라우팅/리플렉션 참조들도 동일한 새 이름으로 업데이트하여 컴파일 오류가 없도록 하십시오.
In
`@src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/dto/CreateWorkspaceReasonCommentRequestDto.java`:
- Around line 15-17: The comment field in CreateWorkspaceReasonCommentRequestDto
currently only has `@NotBlank` and needs a maximum-length validation to prevent
oversized input; add a `@Size`(max = N) annotation on the private String comment
field (choose N to match the domain/DB column limit) and ensure the
corresponding import for javax.validation.constraints.Size (or
jakarta.validation.constraints.Size) is present so validation triggers before
persistence.
In
`@src/main/java/com/dreamteam/alter/application/file/usecase/AppGetPresignedUrl.java`:
- Line 6: AppGetPresignedUrl currently imports the adapter DTO
FilePresignedUrlResponseDto from adapter.inbound.common.dto; change the use case
to return the domain record PresignedUrlResult instead of the adapter DTO by
removing the adapter DTO import and updating the AppGetPresignedUrl method
signature and return value to PresignedUrlResult (adjust any internal variables
like build/construct logic to produce PresignedUrlResult), and move mapping to
FilePresignedUrlResponseDto into the controller layer so controllers convert
PresignedUrlResult -> FilePresignedUrlResponseDto.
In
`@src/main/java/com/dreamteam/alter/application/file/usecase/AppUploadFile.java`:
- Around line 21-22: The field injection annotation `@Resource` on the final
FileUploadService fileUploadService conflicts with constructor injection
provided by Lombok's `@RequiredArgsConstructor`; remove the `@Resource` annotation
so Spring uses the generated constructor to inject FileUploadService (also
remove any unused import for `@Resource` if present) and keep the field final to
preserve constructor injection semantics in AppUploadFile.
In
`@src/main/java/com/dreamteam/alter/application/workspace/usecase/CreateWorkspace.java`:
- Line 9: The application use-case CreateWorkspace currently imports and depends
on the adapter DTO CreateWorkspaceRequestDto; remove that dependency by
introducing a domain-level command interface (e.g., CreateWorkspaceCommand with
getters like getBrn(), getBizName(), getType(), etc.) in the domain workspace
port and change CreateWorkspace to accept that command instead of
CreateWorkspaceRequestDto; update the controller/adapters so their
CreateWorkspaceRequestDto implements the new CreateWorkspaceCommand, remove the
import of CreateWorkspaceRequestDto from CreateWorkspace.java, and wire the
command through the existing inbound port/handler to preserve behavior without
referencing adapter-layer DTOs.
In
`@src/main/java/com/dreamteam/alter/application/workspace/usecase/CreateWorkspaceReasonComment.java`:
- Line 6: The CreateWorkspaceReasonComment use case currently depends on the
inbound adapter DTO CreateWorkspaceReasonCommentRequestDto, breaking layer
boundaries; replace that dependency by defining an application-layer command
(e.g., CreateWorkspaceReasonCommentCommand) in the application/usecase or
application/port package and change the CreateWorkspaceReasonComment class and
its method signature to accept that command instead of
CreateWorkspaceReasonCommentRequestDto; then update the inbound controller to
map CreateWorkspaceReasonCommentRequestDto ->
CreateWorkspaceReasonCommentCommand before calling the use case and remove the
import of CreateWorkspaceReasonCommentRequestDto from the application layer.
In
`@src/main/java/com/dreamteam/alter/application/workspace/usecase/GetWorkspaceReasonComments.java`:
- Line 8: The use case GetWorkspaceReasonComments currently imports and returns
the adapter DTO WorkspaceReasonCommentResponseDto which violates the hexagonal
boundary; change GetWorkspaceReasonComments to return domain entities or domain
DTOs (e.g., List<WorkspaceReasonComment> or a domain-specific DTO) instead of
WorkspaceReasonCommentResponseDto, remove the import of
com.dreamteam.alter.adapter.inbound.manager.workspace.dto.WorkspaceReasonCommentResponseDto
from GetWorkspaceReasonComments, and move the mapping to
WorkspaceReasonCommentResponseDto::from into the controller layer so the
controller maps the domain list to the adapter response DTO before returning the
HTTP response.
In
`@src/main/java/com/dreamteam/alter/domain/file/port/inbound/AppGetPresignedUrlUseCase.java`:
- Around line 3-7: The domain interface AppGetPresignedUrlUseCase currently
returns the adapter DTO FilePresignedUrlResponseDto which inverts hexagonal
dependencies; create a domain-level result type (e.g., PresignedUrlResult record
in domain.file.port.inbound) and change AppGetPresignedUrlUseCase.execute
signature to return PresignedUrlResult instead of FilePresignedUrlResponseDto,
then update the adapter/controller layer to map PresignedUrlResult ->
FilePresignedUrlResponseDto when exposing the API.
In
`@src/main/java/com/dreamteam/alter/domain/file/port/inbound/AppUploadFileUseCase.java`:
- Around line 3-11: The AppUploadFileUseCase interface currently depends on
infrastructure and adapter types
(org.springframework.web.multipart.MultipartFile and AppUploadFileResponseDto);
remove those imports from the domain contract and replace the method signature
to use pure-domain DTOs (e.g., introduce domain.port.inbound.FileUploadCommand
holding InputStream, originalFilename, contentType, size and FileUploadResult
holding fileId or metadata). Update AppUploadFileUseCase.execute to accept
FileUploadCommand and return FileUploadResult, then delegate conversion between
MultipartFile <-> FileUploadCommand and FileUploadResult <->
AppUploadFileResponseDto in the controller/adapter layer.
In
`@src/main/java/com/dreamteam/alter/domain/workspace/entity/WorkspaceReason.java`:
- Around line 61-66: The factory method create(...) currently builds a
WorkspaceReason without validating invariants; update
WorkspaceReason.create(Workspace workspace, WorkspaceReasonStatus status, String
reason) to validate inputs (e.g., Objects.requireNonNull(workspace,
"workspace"), Objects.requireNonNull(status, "status") and ensure reason is
non-null/non-blank or trimmed) and throw a clear
RuntimeException/IllegalArgumentException when invalid, before calling
WorkspaceReason.builder().workspace(...).status(...).reason(...).build(); this
ensures the entity invariants are enforced at creation time.
In
`@src/main/java/com/dreamteam/alter/domain/workspace/entity/WorkspaceReasonComment.java`:
- Around line 5-23: The WorkspaceReasonComment domain class currently contains
Spring/JPA/Lombok infrastructure (annotations like `@Entity`, `@Table`, `@Id`,
`@GeneratedValue`, `@ManyToOne`, `@JoinColumn`, `@CreatedDate`, `@LastModifiedDate`,
`@EntityListeners` and Lombok annotations) and must be converted into a pure
domain model: remove all JPA/Spring/Lombok annotations and infrastructure
imports from WorkspaceReasonComment and keep only plain fields and business
logic; then create a separate persistence-side entity (e.g.,
WorkspaceReasonCommentEntity) in the infra/persistence layer that contains the
removed JPA annotations and mapping to related entities, and add mapping methods
(e.g., toEntity()/fromEntity() or a mapper class) to translate between
WorkspaceReasonComment and WorkspaceReasonCommentEntity so repositories use the
persistence entity while the domain layer remains framework-free.
- Around line 53-57: Validate invariants in WorkspaceReasonComment.create:
ensure the workspaceReason parameter is not null and the comment is not
null/blank (no only-whitespace) before building; if validation fails throw an
appropriate runtime exception (e.g., IllegalArgumentException or
NullPointerException) with a clear message. Update the create factory method in
class WorkspaceReasonComment to perform these checks (refer to method
WorkspaceReasonComment.create and fields workspaceReason and comment) and only
call the builder when inputs pass validation.
In
`@src/main/java/com/dreamteam/alter/domain/workspace/port/inbound/CreateWorkspaceReasonCommentUseCase.java`:
- Around line 3-7: The inbound port CreateWorkspaceReasonCommentUseCase
currently depends on the adapter DTO CreateWorkspaceReasonCommentRequestDto
which breaks layer boundaries; change the method signature of
CreateWorkspaceReasonCommentUseCase.execute(ManagerActor actor, Long
workspaceId, Long reasonId, CreateWorkspaceReasonCommentRequestDto request) to
accept a domain-level input model (e.g., CreateWorkspaceReasonCommentCommand or
CreateWorkspaceReasonCommentRequest in the domain package) instead of the
adapter DTO, keep ManagerActor/workspaceId/reasonId as needed, and move the
mapping from CreateWorkspaceReasonCommentRequestDto→domain model into the
inbound adapter so the domain package has zero infrastructure/adapter
dependencies. Ensure all callers and implementations (use case handler) are
updated to the new domain model.
In
`@src/main/java/com/dreamteam/alter/domain/workspace/port/inbound/CreateWorkspaceUseCase.java`:
- Line 3: The domain interface CreateWorkspaceUseCase currently imports and
depends on adapter DTO CreateWorkspaceRequestDto; remove this adapter-layer
dependency by introducing a domain-side command (e.g., CreateWorkspaceCommand)
or by changing the CreateWorkspaceUseCase method signature to accept explicit
primitive/domain types instead of CreateWorkspaceRequestDto; update
CreateWorkspaceUseCase (and any implementations) to use the new
CreateWorkspaceCommand (or parameter list) and move mapping from DTO→command
into the adapter layer so the domain package no longer references
CreateWorkspaceRequestDto.
In
`@src/main/java/com/dreamteam/alter/domain/workspace/port/inbound/GetWorkspaceReasonCommentsUseCase.java`:
- Around line 5-9: GetWorkspaceReasonCommentsUseCase currently returns an
adapter DTO (WorkspaceReasonCommentResponseDto) which introduces an
infrastructure dependency into the domain port; change the port's execute
signature to return a domain/application model (e.g., a new or existing domain
type like WorkspaceReasonComment or WorkspaceReasonCommentModel) instead of
WorkspaceReasonCommentResponseDto, remove the import of
com.dreamteam.alter.adapter.inbound.manager.workspace.dto.WorkspaceReasonCommentResponseDto,
and keep the ManagerActor and execute(ManagerActor actor, Long workspaceId, Long
reasonId) parameters unchanged; then update the inbound adapter/controller that
implements this port to map from the domain model to
WorkspaceReasonCommentResponseDto before returning to the client.
---
Duplicate comments:
In
`@src/main/java/com/dreamteam/alter/adapter/inbound/general/file/controller/AppFileController.java`:
- Around line 33-40: The fields appUploadFile, appGetPresignedUrl, and
appDeleteFile in AppFileController are annotated with `@Resource` while declared
final, which conflicts with constructor-based injection; remove the `@Resource`
annotations from those fields and add a constructor for AppFileController that
accepts the three use-case parameters and assigns them to the final fields,
applying `@Qualifier`("appUploadFile"), `@Qualifier`("appGetPresignedUrl"), and
`@Qualifier`("appDeleteFile") to the corresponding constructor parameters to
preserve bean selection.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: bdcdf009-7e1d-4e80-bcec-a830be5c9e35
📒 Files selected for processing (41)
src/main/java/com/dreamteam/alter/adapter/inbound/general/file/controller/AppFileController.javasrc/main/java/com/dreamteam/alter/adapter/inbound/general/file/controller/AppFileControllerSpec.javasrc/main/java/com/dreamteam/alter/adapter/inbound/general/file/dto/AppUploadFileResponseDto.javasrc/main/java/com/dreamteam/alter/adapter/inbound/general/workspace/controller/UserWorkspaceController.javasrc/main/java/com/dreamteam/alter/adapter/inbound/general/workspace/controller/UserWorkspaceControllerSpec.javasrc/main/java/com/dreamteam/alter/adapter/inbound/general/workspace/dto/CreateWorkspaceRequestDto.javasrc/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.javasrc/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentControllerSpec.javasrc/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/dto/CreateWorkspaceReasonCommentRequestDto.javasrc/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/dto/WorkspaceReasonCommentResponseDto.javasrc/main/java/com/dreamteam/alter/adapter/outbound/user/persistence/ManagerUserJpaRepository.javasrc/main/java/com/dreamteam/alter/adapter/outbound/user/persistence/ManagerUserRepositoryImpl.javasrc/main/java/com/dreamteam/alter/adapter/outbound/workspace/persistence/WorkspaceReasonCommentJpaRepository.javasrc/main/java/com/dreamteam/alter/adapter/outbound/workspace/persistence/WorkspaceReasonCommentQueryRepositoryImpl.javasrc/main/java/com/dreamteam/alter/adapter/outbound/workspace/persistence/WorkspaceReasonCommentRepositoryImpl.javasrc/main/java/com/dreamteam/alter/adapter/outbound/workspace/persistence/WorkspaceReasonJpaRepository.javasrc/main/java/com/dreamteam/alter/adapter/outbound/workspace/persistence/WorkspaceReasonQueryRepositoryImpl.javasrc/main/java/com/dreamteam/alter/adapter/outbound/workspace/persistence/WorkspaceRepositoryImpl.javasrc/main/java/com/dreamteam/alter/application/file/usecase/AppDeleteFile.javasrc/main/java/com/dreamteam/alter/application/file/usecase/AppGetPresignedUrl.javasrc/main/java/com/dreamteam/alter/application/file/usecase/AppUploadFile.javasrc/main/java/com/dreamteam/alter/application/file/usecase/AttachFiles.javasrc/main/java/com/dreamteam/alter/application/workspace/usecase/CreateWorkspace.javasrc/main/java/com/dreamteam/alter/application/workspace/usecase/CreateWorkspaceReasonComment.javasrc/main/java/com/dreamteam/alter/application/workspace/usecase/GetWorkspaceReasonComments.javasrc/main/java/com/dreamteam/alter/domain/file/port/inbound/AppDeleteFileUseCase.javasrc/main/java/com/dreamteam/alter/domain/file/port/inbound/AppGetPresignedUrlUseCase.javasrc/main/java/com/dreamteam/alter/domain/file/port/inbound/AppUploadFileUseCase.javasrc/main/java/com/dreamteam/alter/domain/file/port/inbound/AttachFilesUseCase.javasrc/main/java/com/dreamteam/alter/domain/file/type/FileTargetType.javasrc/main/java/com/dreamteam/alter/domain/user/port/outbound/ManagerUserRepository.javasrc/main/java/com/dreamteam/alter/domain/workspace/entity/WorkspaceReason.javasrc/main/java/com/dreamteam/alter/domain/workspace/entity/WorkspaceReasonComment.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/inbound/CreateWorkspaceReasonCommentUseCase.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/inbound/CreateWorkspaceUseCase.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/inbound/GetWorkspaceReasonCommentsUseCase.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/outbound/WorkspaceReasonCommentQueryRepository.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/outbound/WorkspaceReasonCommentRepository.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/outbound/WorkspaceReasonQueryRepository.javasrc/main/java/com/dreamteam/alter/domain/workspace/port/outbound/WorkspaceRepository.javasrc/main/java/com/dreamteam/alter/domain/workspace/type/WorkspaceReasonStatus.java
...om/dreamteam/alter/adapter/inbound/general/workspace/controller/UserWorkspaceController.java
Show resolved
Hide resolved
...er/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.java
Show resolved
Hide resolved
...dapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentControllerSpec.java
Outdated
Show resolved
Hide resolved
...team/alter/adapter/inbound/manager/workspace/dto/CreateWorkspaceReasonCommentRequestDto.java
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/application/file/usecase/AppGetPresignedUrl.java
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/domain/workspace/entity/WorkspaceReasonComment.java
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/domain/workspace/entity/WorkspaceReasonComment.java
Show resolved
Hide resolved
...a/com/dreamteam/alter/domain/workspace/port/inbound/CreateWorkspaceReasonCommentUseCase.java
Show resolved
Hide resolved
src/main/java/com/dreamteam/alter/domain/workspace/port/inbound/CreateWorkspaceUseCase.java
Show resolved
Hide resolved
...ava/com/dreamteam/alter/domain/workspace/port/inbound/GetWorkspaceReasonCommentsUseCase.java
Show resolved
Hide resolved
There was a problem hiding this comment.
♻️ Duplicate comments (1)
src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.java (1)
34-38:⚠️ Potential issue | 🟠 Major
@Resource필드 주입과final +@RequiredArgsConstructor`` 혼용을 제거하세요.현재 주입 방식이 혼재되어 의도와 동작이 불명확합니다. 생성자 주입으로 통일하는 편이 안전합니다.
🔧 권장 수정안
-import jakarta.annotation.Resource; +import org.springframework.beans.factory.annotation.Qualifier; @@ - `@Resource`(name = "createWorkspaceReasonComment") + `@Qualifier`("createWorkspaceReasonComment") private final CreateWorkspaceReasonCommentUseCase createWorkspaceReasonComment; @@ - `@Resource`(name = "getWorkspaceReasonComments") + `@Qualifier`("getWorkspaceReasonComments") private final GetWorkspaceReasonCommentsUseCase getWorkspaceReasonComments;#!/bin/bash # 목적: final 필드에 `@Resource를` 적용한 혼용 패턴 탐지 및 현재 컨트롤러 상태 확인 rg -n -U --type java '@Resource\(name\s*=\s*"[^"]+"\)\s*\n\s*private final' rg -n --type java 'class ManagerWorkspaceReasonCommentController|@RequiredArgsConstructor|@Resource|@Qualifier' -A4 -B4 src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.java🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.java` around lines 34 - 38, ManagerWorkspaceReasonCommentController mixes field `@Resource` injection with final fields and constructor-based `@RequiredArgsConstructor`; unify to constructor injection: remove the `@Resource`(name = "...") annotations from the final fields CreateWorkspaceReasonCommentUseCase createWorkspaceReasonComment and GetWorkspaceReasonCommentsUseCase getWorkspaceReasonComments, keep them as final fields, ensure the class is annotated with Lombok's `@RequiredArgsConstructor` (or add it if missing) so Spring will use constructor injection, and if you need specific bean names keep the bean selection via `@Qualifier` on the constructor parameters rather than `@Resource` on fields.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In
`@src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.java`:
- Around line 34-38: ManagerWorkspaceReasonCommentController mixes field
`@Resource` injection with final fields and constructor-based
`@RequiredArgsConstructor`; unify to constructor injection: remove the
`@Resource`(name = "...") annotations from the final fields
CreateWorkspaceReasonCommentUseCase createWorkspaceReasonComment and
GetWorkspaceReasonCommentsUseCase getWorkspaceReasonComments, keep them as final
fields, ensure the class is annotated with Lombok's `@RequiredArgsConstructor` (or
add it if missing) so Spring will use constructor injection, and if you need
specific bean names keep the bean selection via `@Qualifier` on the constructor
parameters rather than `@Resource` on fields.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: a3831959-4a95-499e-bfa1-717c73fc7dd1
📒 Files selected for processing (2)
src/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentController.javasrc/main/java/com/dreamteam/alter/adapter/inbound/manager/workspace/controller/ManagerWorkspaceReasonCommentControllerSpec.java
ysw789
requested changes
Mar 25, 2026
Contributor
ysw789
left a comment
ysw789
left a comment
There was a problem hiding this comment.
- 현재 댓글 작성/조회 API가 매니저 전용(/manager/..., ManagerActor)으로만 구현되어 있는데, 일반 사용자도 자기 신청 건에 대해 댓글을 작성/조회할 수 있어야 합니다. 일반 사용자용 API도 파주세요~ 만약 같은 UseCase를 참조해도 되는 경우면 전에 얘기했듯이 헥사고날 아키텍처 구체화해서 command dto로 인자 주고받도록 구성해도 괜찮을 듯 해요
- 관리자(ADMIN)이 신청 상태를 바꾸고 댓글을 작성/조회하는 API도 필요할 것 같습니다. 등록 신청 최종 승인자는 ADMIN입니다
- 업장 등록 신청이 승인 될 경우 User.role을
ROLE_MANAGER로 변경해야 하는데, 만일 사용자가 이미ROLE_MANAGER인 경우에 대한 조건 처리도 포함해주세요 (다른 업장을 이미 등록한 상태라면 매니저임)
Comment on lines
+20
to
+22
| private Long id; | ||
| private String comment; | ||
| private LocalDateTime createdAt; |
| public class CreateWorkspaceReasonCommentRequestDto { | ||
|
|
||
| @Schema(description = "댓글 내용", example = "왜 반려죠") | ||
| @Max(255) |
Contributor
There was a problem hiding this comment.
Max 는 정수값 제한에 사용되는 어노테이션이라 문자열 길이 제한하려면 Size 어노테이션으로 바꿔주세요
| request.getTown(), | ||
| request.getLatitude(), | ||
| request.getLongitude() | ||
| ); |
Contributor
There was a problem hiding this comment.
업장 등록 신청 생성 시점에 ManagerUser, Worksapce를 생성하는 것 보단, ADMIN에 의한 최종 승인 시 ManagerUser로 전환하고 Workspace를 만드는 게 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
관련 문서
https://www.notion.so/BE-317865531628803b9e67c82adb3f67c3?v=2b186553162880979f62000c6c946512&source=copy_link
Summary by CodeRabbit