fix: fix undefined behavior with mutable references#583
Draft
Conversation
✅ Deploy Preview for tealscript ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ensures we only count references in an array when the value is mutable. Also accounts for state values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently TEALScript has undefined behavior with mutable references. The two sceanrios that result in UB are
const) references to mutable objectsThis PR adds a reference checker to ensure those scenarios do not occur. The only material change for developers is the need to add a
clonehere or there, but as seen in this PR it is not needed in many cases.ab0d526 was the initial reference checking implementation which used the architecture of TEALScript to check problematic areas
702e43b is (the start of) an implementation-agnostic reference checker that works solely on the TypeScript AST. This means the work here should be applicable to both TEALScript and Puya TS.