feat(opus and fragments): add support for opus and writing fragmented mp4 files#114
Open
sdwoodbury wants to merge 24 commits intoalfg:masterfrom
Open
feat(opus and fragments): add support for opus and writing fragmented mp4 files#114sdwoodbury wants to merge 24 commits intoalfg:masterfrom
sdwoodbury wants to merge 24 commits intoalfg:masterfrom
Conversation
sdwoodbury
commented
Jul 14, 2023
sdwoodbury
commented
Jul 14, 2023
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this repository I made a tool that managed to write a fragmented mp4 file. This was accomplished by fixing a bunch of bugs in this repository (wrong reported box sizes and not writing all the needed boxes) and by exposing the boxes so that I could create the file programmatically.
Eventually it would be nice to have something like Mp4Writer but I also think it makes this library more useful if the boxes aren't all private.
I added a box for Opus and dOps per this guide: https://opus-codec.org/docs/opus_in_isobmff.html
One last thing - the mvex box was changed to contain a list of trex boxes, which is necessary if an mp4 file will contain multiple tracks.