Заменить class reopening на вложенную структуру модулей#166
Open
Заменить class reopening на вложенную структуру модулей#166
Conversation
…tra blank line in QIWI payout
… payout destination message; tronscan successful?
- Remove begin/rescue wrapper around enum in PaymentCard for Rails 8 - Fix Payment workflow state expectations in tests (succeed/failed instead of success/fail) - Fix Payment spec mocking to use allow_any_instance_of for workflow callbacks - Set rbk_money_invoice_id directly to ensure proper association 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Simplify PaymentCard enum declaration (remove attribute declaration) - Add explicit return values to workflow mocks to ensure proper execution - Update Invoice spec to return true from auto_confirm! mock 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Use Rails 8 enum syntax: enum :attribute_name, { values }, options
instead of: enum attribute_name: { values }, _prefix: option
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Handle empty bin strings in masked_number method - Add persist_workflow_state method to Payment and Invoice for Rails 8 compatibility - Workflow gem requires explicit persistence method in Rails 8 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dapi
requested changes
Dec 9, 2025
dapi
left a comment
dapi
left a comment
There was a problem hiding this comment.
Помимо class -> module тут еще залетало изменение логики - WorkflowActivercord заменился на WOrkfflow, что не верно.
Очевидно это привело к появлению новых методов которые лишние
.ruby-version лучше не добавлять и перейти на mise
| state :refunded | ||
| end | ||
|
|
||
| def persist_workflow_state(new_value) |
There was a problem hiding this comment.
А это точно нужно? Зачем? Выглядит как будто что-то не учли
| @@ -0,0 +1 @@ | |||
| 3.4.7 | |||
There was a problem hiding this comment.
Версия ruby есть в mise.toml
Не стоит держать версии в двух разных источниках потому что это приведет к путанице.
| module PaymentServices | ||
| class AdvCash | ||
| class Payout < ApplicationRecord | ||
| include Workflow |
There was a problem hiding this comment.
Тут произошла путаница WorkflowActiverecord заменен на Workflow, а это явно ошибка
| module PaymentServices | ||
| class AliKassa | ||
| class Invoice < ApplicationRecord | ||
| include Workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#165