Fix File Provider after Sparkle updates and Open in Finder sandbox issue#12
Merged
alexmodrono merged 3 commits intomainfrom Mar 18, 2026
Merged
Fix File Provider after Sparkle updates and Open in Finder sandbox issue#12alexmodrono merged 3 commits intomainfrom
alexmodrono merged 3 commits intomainfrom
Conversation
- Re-store keychain token after version change and during reset to ensure accessibility from the updated extension binary - Replace fixed 2s sleep with retry loop (up to 5 attempts with increasing backoff) for shared database seeding - Replace silent try? with proper try/catch and OSLog diagnostics so failures during re-registration and reset are visible - Apply the same improvements to both reregisterFileProviderDomain (automatic on version change) and resetProvider (manual from Settings)
Root cause: When Sparkle replaces the app bundle, macOS disables the embedded File Provider extension via pluginkit. NSFileProviderManager .add(domain) does NOT re-enable a disabled extension — only `pluginkit -e use -i <bundle-id>` does. The app now calls `pluginkit -e use` to re-enable the extension: - On every app launch (in ensureFileProviderDomain) - After detecting a version change (in reregisterFileProviderDomain) - During manual Reset Provider (in resetProvider) This is safe to call unconditionally — pluginkit is idempotent and returns immediately if the extension is already enabled.
NSWorkspace.shared.open() is blocked by the app sandbox for File Provider CloudStorage URLs, producing "does not have permission" errors. Switch to selectFile(inFileViewerRootedAtPath:) which asks Finder to navigate to the path instead of the app opening it directly.
Nightly BuildDownload Findle Nightly (unsigned) Built from e24aa2f. Important This build is unsigned. macOS will block it on first launch. To open it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pluginkit -e useon every launchDetails
Root cause of the File Provider issue: when Sparkle replaces the app bundle, macOS disables the embedded File Provider extension via pluginkit.
NSFileProviderManager.add(domain)does NOT re-enable it. The fix callspluginkit -e useon every app launch.The "Open in Finder" issue was caused by
NSWorkspace.shared.open()being blocked by the sandbox for File Provider CloudStorage URLs after the binary changed. Switched toselectFile(inFileViewerRootedAtPath:).