Skip to content

fix(caa): add support for issuevmc #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexdalitz merged 1 commit into from
Oct 31, 2025
Merged

fix(caa): add support for issuevmc #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/dnsruby/resource/CAA.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class CAA < RR
ClassValue = nil #:nodoc: all
TypeValue= Types::CAA #:nodoc: all

# The property tag for the record (issue|issuewild|iodef)
# The property tag for the record (issue|issuewild|issuemail|issuevmc|iodef|contactemail|contactphone)
attr_accessor :property_tag
# The value for the property_tag
attr_accessor :property_value
Expand All @@ -43,7 +43,7 @@ def flag
end

def from_string(input) #:nodoc: all
matches = (/(\d+) (issuewild|issuemail|issue|iodef|contactemail|contactphone) "(.+)"$/i).match(input)
matches = (/(\d+) (issuewild|issuemail|issuevmc|issue|iodef|contactemail|contactphone) "(.+)"$/i).match(input)
if matches.nil?
raise DecodeError.new("Cannot parse record: #{input[0...1000]}")
end
Expand Down
1 change: 1 addition & 0 deletions test/tc_caa.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ def test_caa
'foo.com. IN CAA 1 issue "ca.example.net"' => [1, 'issue', 'ca.example.net'],
'foo.com. IN CAA 0 issuewild "ca.example.net"' => [0, 'issuewild', 'ca.example.net'],
'foo.com. IN CAA 0 issuemail "ca.example.net"' => [0, 'issuemail', 'ca.example.net'],
'foo.com. IN CAA 0 issuevmc "ca.example.net"' => [0, 'issuevmc', 'ca.example.net'],
'foo.com. IN CAA 0 iodef "mailto:security@example.com"' => [0, 'iodef', 'mailto:security@example.com'],
'foo.com. IN CAA 0 issue "ca.example.net; account=230123"' => [0, 'issue', 'ca.example.net; account=230123']
}.each do |text, data|
Expand Down