This repository was archived by the owner on Oct 2, 2023. It is now read-only.
fix: Addressed robocopy deployment errors on Windows.#236
Open
fix: Addressed robocopy deployment errors on Windows.#236
Conversation
Caused by "extra" deployment files (skill JS and readme) in destination directory, which cause a non-critical robocopy error code 2. resolves issue #151
joseifert
force-pushed
the
fix-windows-robocopy
branch
from
c7204d2 to
6c46afe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by "extra" deployment files (skill JS and readme) in destination directory, which cause a non-critical robocopy error code 2.
resolves issue #151
Description
Added ignore for robocopy error code 2, which complains about extra files in the destination directory. This currently causes the deployment promise chain to reject/abort, even though it isn't a critical error as the /MIR flag for the robocopy command purges those extra files.
Testing
Tested on Windows on Litexa packages 0.8.0 - was able to consistently reproduce the deployment failure pre-change, and can no longer reproduce post-change.