Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a BETA feature flag for a custom envoy side car on an application. The primary use of this feature is to have the region-api add a side-car to the application that contains a custom LUA script that intercepts requests, validates authorization, and responds appropriate or forwards the request on to the app.
Once this functionality has been tested and verified to be stable and production ready, it will be removed from BETA status.
This code requires that some work needs to be created on the region-api and that this controller-api PR be merged & deployed to work properly. The region-api so that Custom Envoy Sidecar is created for the app/pod with the feature flag enabled from the controller-api.