Skip to content

Adds Docker watcher ability to use images without tags#221

Open
merimna wants to merge 1 commit intoairbnb:masterfrom
merimna:docker-image-no-tag
Open

Adds Docker watcher ability to use images without tags#221
merimna wants to merge 1 commit intoairbnb:masterfrom
merimna:docker-image-no-tag

Conversation

@merimna
Copy link

@merimna merimna commented Feb 15, 2017

Really useful for local dev where an image might not have a tag yet.

The fix here was to use split instead of rpartition because rpartition has some unexpected behavior when there is no match.

"foo:bar".rpartition(":")    # ["foo", ":", "bar"]

"foo".rpartition(":")        # ["", "", "foo"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant