docs(k8s): clarify Dynamo/Grove/KAI ownership and deployment modes#6888
docs(k8s): clarify Dynamo/Grove/KAI ownership and deployment modes#6888
Conversation
WalkthroughDocumentation enhancements across three Kubernetes deployment guides clarifying responsibility splits between cluster admins, users, and operators; updating Grove/KAI Scheduler dependency requirements; and adding detailed role definitions for Dynamo deployments. No code logic modifications. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/kubernetes/grove.md (1)
94-104:⚠️ Potential issue | 🟡 MinorUse the canonical Grove repository links in this section.
In the same changed section (Line 98 and Line 102), Grove links still point to
github.com/NVIDIA/grove. Please switch them tohttps://github.com/ai-dynamo/groveto avoid directing users to a non-canonical source.Suggested doc fix
-For installation instructions, see the [Grove Installation Guide](https://github.com/NVIDIA/grove/blob/main/docs/installation.md). +For installation instructions, see the [Grove Installation Guide](https://github.com/ai-dynamo/grove/blob/main/docs/installation.md). -For the latest updates on Grove, refer to the [official project on GitHub](https://github.com/NVIDIA/grove). +For the latest updates on Grove, refer to the [official project on GitHub](https://github.com/ai-dynamo/grove).Based on learnings: The canonical Grove repository URL is https://github.com/ai-dynamo/grove, not https://github.com/NVIDIA/grove.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/kubernetes/grove.md` around lines 94 - 104, Replace the non-canonical Grove repository URLs in the markdown section: update any occurrences of "https://github.com/NVIDIA/grove" (seen in the link targets in the lines referencing the Grove Installation Guide and the "official project on GitHub") to the canonical "https://github.com/ai-dynamo/grove"; ensure both link targets are changed so the Installation Guide and project link point to ai-dynamo/grove.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@docs/kubernetes/grove.md`:
- Around line 94-104: Replace the non-canonical Grove repository URLs in the
markdown section: update any occurrences of "https://github.com/NVIDIA/grove"
(seen in the link targets in the lines referencing the Grove Installation Guide
and the "official project on GitHub") to the canonical
"https://github.com/ai-dynamo/grove"; ensure both link targets are changed so
the Installation Guide and project link point to ai-dynamo/grove.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 384b403e-5b16-4451-81d7-1738e5f99761
📒 Files selected for processing (3)
docs/kubernetes/deployment/multinode-deployment.mddocs/kubernetes/grove.mddocs/kubernetes/installation-guide.md
Summary
Why
This makes the ownership and deployment contract explicit and removes ambiguity about when Grove and KAI are installed by Dynamo versus pre-provisioned by cluster administrators.
Summary by CodeRabbit