Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a recurring CI failure on the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request disables the CDX-AG-002 rule in agnix to resolve a false positive secret detection in AGENTS.md. While this fixes the immediate CI failure, I've raised a concern about disabling a security rule globally. My feedback suggests exploring a more scoped-down approach to disabling the rule, if the tool supports it, to avoid potentially missing real secrets in the future.
| "CC-SK-017", # Intentional - version is a client-specific frontmatter field | ||
| "XP-003", # Intentional - lib/cross-platform/RESEARCH.md documents all platform paths | ||
| "CC-MEM-004", # npm validate referenced in auto-generated CLAUDE.md (agent-core template issue) | ||
| "CDX-AG-002", # False positive - "Token efficiency" in AGENTS.md is not a secret |
There was a problem hiding this comment.
Disabling a secret detection rule globally for the entire repository can be a security risk, as it may prevent the detection of actual secrets committed in other files in the future. A more secure approach is to scope the exception as narrowly as possible. If agnix supports a more granular configuration, please consider disabling this rule only for AGENTS.md to limit the scope of this exception.
Agnix CI fails on main with
CDX-AG-002: Potential secret detected in AGENTS.md. The trigger is the text 'Token efficiency' which is not a secret — it's an ecosystem-wide boilerplate instruction from agent-core sync.This adds CDX-AG-002 to disabled_rules with a comment explaining the false positive, matching the pattern already used in agent-sh/agentsys.