refactor: decouple delivery agents to prepare-delivery plugin + repo-intel rename#26
refactor: decouple delivery agents to prepare-delivery plugin + repo-intel rename#26
Conversation
Both git-map and repo-map plugins are being consolidated into repo-intel.
Updates /repo-map init suggestions to /repo-intel init, and updates
getPluginRoot('git-map') and lib/git-map/queries to repo-intel equivalents.
Move delivery-validator, test-coverage-checker agents and orchestrate-review, validate-delivery skills to prepare-delivery plugin. next-task now references these as prepare-delivery:* cross-plugin agents. Phases 8-11 functionality unchanged - just owned by prepare-delivery now.
Remove delivery-validator, test-coverage-checker agents and orchestrate-review, validate-delivery skills that were copied to prepare-delivery but not deleted here. The files were not in components.json but could shadow the prepare-delivery versions. Also fix stale Phase 10 comment (next-task: -> prepare-delivery:).
Fix bare delivery-validator and test-coverage-checker references missed in the initial decoupling commit. Now all references use the prepare-delivery: prefix consistently. Updated: implementation-agent.md, next-task.md (gates table), README.md, lib/adapter-transforms.js
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the agent architecture by extracting delivery-related agents and skills into a dedicated Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project by moving delivery validation and test coverage agents and skills (e.g., delivery-validator, test-coverage-checker, orchestrate-review, validate-delivery) into a new prepare-delivery plugin. This change involves updating all internal references to these components with the prepare-delivery: prefix and consistently renaming git-map/repo-map references to repo-intel throughout the codebase and documentation. The documentation files AGENTS.md, CHANGELOG.md, CLAUDE.md, and README.md have been updated accordingly, and the original agent/skill definitions have been removed. Feedback suggests improving error handling in agents/planning-agent.md by logging the error object in catch blocks for better debugging.
| } catch { | ||
| console.log('[WARN] git-map plugin found but queries failed to load'); | ||
| console.log('[WARN] repo-intel plugin found but queries failed to load'); | ||
| } |
There was a problem hiding this comment.
The catch block currently swallows the actual error, which can make debugging difficult. It's a good practice to log the error object for better diagnostics, as per our general rules.
Consider capturing and logging the error, like this:
} catch (e) {
console.log('[WARN] repo-intel plugin found but queries failed to load', e);
}| } catch { | |
| console.log('[WARN] git-map plugin found but queries failed to load'); | |
| console.log('[WARN] repo-intel plugin found but queries failed to load'); | |
| } | |
| } catch (e) { | |
| console.log('[WARN] repo-intel plugin found but queries failed to load', e); | |
| } |
References
- In helper functions that catch and handle errors, log the error along with relevant context, such as input arguments, to ensure failures are visible and debuggable.
Summary
delivery-validator,test-coverage-checker(agents),orchestrate-review,validate-delivery(skills)next-task:*toprepare-delivery:*in commands, hooks, CLAUDE.md, AGENTS.md, README.md, adapter-transformsMotivation
Part of the composable delivery pipeline work. The new plugin architecture:
/prepare-delivery- quality gates (deslop, review, validation, docs sync)/gate-and-ship- chains /prepare-delivery then /ship/next-task- full orchestrator, now references prepare-delivery for phases 8-11Test plan
npm testpassesprepare-delivery:*cross-plugin references resolve correctlydelivery-validatorortest-coverage-checkerreferences remain