Merged
Conversation
Owner
|
CI error is due to the setup python action no longer supporting 3.7. Merging, thanks. I'll push it to crates.io later. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking at the code I noticed that the last error coefficient for the RK3(2) scheme was missing a minus sign.
This wasn't noticed because there was no unit test for this solver and because the doc tests do not actually run since the function that's supposed to execute code is called
exampleinstead ofmain. Without the minus sign, the RK5(4) tests fail for RK3(2). BTW, neither the RK5(4) example nor the RK3(2) example (even after fixing the sign) runs successfully (I'm not sure why, the tests in the test module do run successfully).I took that opportunity to fix the doc comment for the RK3(2) scheme which had 5(4) in it.
Note that after a bit of tinkering I was able to leverage rstest to make the RK tests parametrized over the solver so as to avoid code duplication (finding the right type with the right generics wasn't easy...).