Skip to content

[CLIENT-4436] Add quality-of-life improvements for path expressions#1002

Draft
juliannguyen4 wants to merge 46 commits intodevfrom
CLIENT-4436-path-expressions-improvements
Draft

[CLIENT-4436] Add quality-of-life improvements for path expressions#1002
juliannguyen4 wants to merge 46 commits intodevfrom
CLIENT-4436-path-expressions-improvements

Conversation

@juliannguyen4
Copy link
Copy Markdown
Collaborator

@juliannguyen4 juliannguyen4 commented Mar 23, 2026

Extra Changes

  • Add cross reference from path expressions / operations to RemoveResult
  • Document why we have QOL improvements via cross references
  • Refactor aerospike_helpers.cdt_ctx conversion code by moving individual _cdt_ctx conversion to a separate method. This reduces the number of indents in the get_cdt_ctx helper function.
  • Remove some unused imports in test_path_expressions.py
  • Move path expressions into their own section. Deprecate the usage in the base package
  • Check that this feature fails for server < 8.1.2

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 23, 2026

Codecov Report

❌ Patch coverage is 92.50000% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.87%. Comparing base (274742f) to head (6bff3bd).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
src/main/conversions.c 90.69% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1002      +/-   ##
==========================================
+ Coverage   83.83%   83.87%   +0.04%     
==========================================
  Files          99       99              
  Lines       14429    14481      +52     
==========================================
+ Hits        12096    12146      +50     
- Misses       2333     2335       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliannguyen4 juliannguyen4 force-pushed the CLIENT-4436-path-expressions-improvements branch from 079f321 to 86f7f3f Compare March 25, 2026 16:24
…_version fixture, so we need to check if parameter exists in the fixture or we will get an error
…o we don't have to update the magic numbers in the tests..
…on-native list value unless we wrap around the Val() expr
…t of keys. We can compare dicts in Python without caring about the key order. Only sort the results when returning a list of unordered map elements
…nt from the aerospike server). I believe this alternative should work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants