Refactored metric collecting of limit/usage, also includes nr of free workers.#113
Merged
Hilbrand merged 3 commits intoaerius:mainfrom Apr 3, 2026
Merged
Conversation
Member
|
Is this so that we don't have to use the RabbitMQ metrics for this? |
BertScholten
reviewed
Mar 4, 2026
Member
BertScholten
left a comment
BertScholten
left a comment
There was a problem hiding this comment.
Can see it having benefit next to rabbitmq metrics (there can be a difference between the two, which is also useful information).
Would it be an idea to also add .work.total and/or .work.used for completeness? Think you can figure those out based on free and load, but might as well be explicit about those.
Hilbrand
changed the title
Hilbrand
force-pushed
the
add-free-workers-metric
branch
from
d1a39d3 to
f6051eb
Compare
Hilbrand
force-pushed
the
add-free-workers-metric
branch
from
f6051eb to
aaadb95
Compare
…emetry standards Added new usage metrics for weighted metrics, workerpool and RabbitMQ derived usage values. Used limit/usage with attributes naming as suggested by best practices of OpenTelemetry.
Hilbrand
force-pushed
the
add-free-workers-metric
branch
from
aaadb95 to
e598d7a
Compare
Hilbrand
changed the title
Member
Author
|
@SerhatG @BertScholten I've rewritten this pr to have a more consistent approach for reporting among other things free workers. For the naming conventions I followed the OpenTelemetry suggested best practices: https://opentelemetry.io/docs/specs/semconv/general/naming/#instrument-naming |
BertScholten
requested changes
Mar 31, 2026
.../taskmanager-client/src/main/java/nl/aerius/taskmanager/client/mq/RabbitMQWorkerMonitor.java
Show resolved
Hide resolved
source/taskmanager/src/main/java/nl/aerius/taskmanager/metrics/UsageMetricsProvider.java
Outdated
Show resolved
Hide resolved
source/taskmanager/src/main/java/nl/aerius/taskmanager/metrics/UsageMetricsReporter.java
Outdated
Show resolved
Hide resolved
source/taskmanager/src/main/java/nl/aerius/taskmanager/TaskManager.java
Outdated
Show resolved
Hide resolved
source/taskmanager/src/main/java/nl/aerius/taskmanager/TaskManager.java
Outdated
Show resolved
Hide resolved
source/taskmanager/src/main/java/nl/aerius/taskmanager/WorkerPoolMetrics.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored initial commit to have a better more consistent implementation. This is in the second commit e598d7a