Fix stderr redirections for git commands on Windows#62
Open
JacobusXIII wants to merge 2 commits intoaerius:mainfrom
Open
Fix stderr redirections for git commands on Windows#62JacobusXIII wants to merge 2 commits intoaerius:mainfrom
JacobusXIII wants to merge 2 commits intoaerius:mainfrom
Conversation
BertScholten
approved these changes
Apr 7, 2026
bin/GitUtility.rb
Outdated
| curr_dir = Dir.pwd | ||
| Dir.chdir(dir) | ||
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + ' ' + args + ' 2>/dev/null' | ||
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + ' ' + args + ' ' + git_stderr_null |
Member
There was a problem hiding this comment.
Suggested change
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + ' ' + args + ' ' + git_stderr_null | |
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + "#{args} #{git_stderr_null}" |
Assuming this works as well, but might want to test it ;)
Contributor
There was a problem hiding this comment.
tested it; that doesn't work ;)
Contributor
Author
There was a problem hiding this comment.
Suggested change
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + ' ' + args + ' ' + git_stderr_null | |
| cmd = "#{$git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\""} #{args} #{git_stderr_null}" |
A this one @eltee1?
Contributor
There was a problem hiding this comment.
Yep, this works; build continues ;)
eltee1
approved these changes
Apr 7, 2026
Contributor
eltee1
left a comment
eltee1
left a comment
There was a problem hiding this comment.
Tested change, works like a charm !
LGTM ;)
bin/GitUtility.rb
Outdated
| curr_dir = Dir.pwd | ||
| Dir.chdir(dir) | ||
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + ' ' + args + ' 2>/dev/null' | ||
| cmd = ($git_bin_path.to_s.empty? ? 'git' : "\"#{$git_bin_path}git\"") + ' ' + args + ' ' + git_stderr_null |
Contributor
There was a problem hiding this comment.
tested it; that doesn't work ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.