Add logic for logging git-hash of database-build- and modules in database.#58
Open
eltee1 wants to merge 4 commits intoaerius:mainfrom
Open
Add logic for logging git-hash of database-build- and modules in database.#58eltee1 wants to merge 4 commits intoaerius:mainfrom
eltee1 wants to merge 4 commits intoaerius:mainfrom
Conversation
…d database-modules to Utillity.rb and use those new functions for logging these git-hashes in the system.constants table by additions to the function add_build_constants.
BertScholten
requested changes
Mar 2, 2026
…d function that checks for uncommitted code and fails the build if finds any. Todo: implement the call of that function.
…he load.rb of the product.
…ase-modules from ScriptCommands.rb to load.rb in Monitor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions specific for getting the git hash for database-build and database-modules to Utillity.rb and use those new functions for logging these git-hashes in the system.constants table by additions to the function add_build_constants.
For this functionality to work, the constants which state the correct paths of the database-build and database-modules must be added in the settings.rb file of the corresponding product (in this case Monitor). For this, a PR is made in the Monitor- repo: PR#754.
It works, but maybe this can be solved more generically, so for now I added the label WIP.