refactor: consolidate 0-slots handling to rely on markdown#84
Merged
melissag-ensemble merged 1 commit intomainfrom Mar 11, 2026
Merged
refactor: consolidate 0-slots handling to rely on markdown#84melissag-ensemble merged 1 commit intomainfrom
melissag-ensemble merged 1 commit intomainfrom
Conversation
2b18d8c to
697a9f4
Compare
697a9f4 to
f0bf10f
Compare
f0bf10f to
916582d
Compare
louisachu
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduce the three ways we end up with 0
slotsto a single approach.Previous approaches:
HorizontalLine-slotswas forced to[], sototalSlots = repeat * 0 = 0Fragment/iframe-repeatwas forced to0, sototalSlots = 0 * slots.length = 0slotsis missing or empty, parsing yields[], sototalSlots = repeat * 0 = 0All three produced 0 nodes consumed as
slotcontent, but via different logic. This PR consolidates on # 3 to treat the markdown document as the source of truth - if a block has noslotsattribute (or it's empty), treat it as 0slots.Test