Conversation
… buttons in dark mode Made-with: Cursor
…ility - Refactored grpc-test.json to enhance the structure and ensure better compatibility with the API documentation. - Removed outdated entries and streamlined the data format for clarity and efficiency. - This change aims to support future enhancements and maintain consistency across the API models.
leandrogilcarrano
previously approved these changes
Mar 10, 2026
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Alex Perez <a***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
alexpmule
force-pushed
the
fix/dark-mode-union-buttons
branch
from
be34258 to
86a320d
Compare
grpc-test.json was replaced with a different model; tests expect SayHello1/SayHello2 and link-target structure. Use grpc-test-old.json and add it to repo (exception in .gitignore) so CI passes. Made-with: Cursor
alexpmule
force-pushed
the
fix/dark-mode-union-buttons
branch
from
d4848f9 to
c292d38
Compare
Made-with: Cursor
leandrogilcarrano
approved these changes
Mar 10, 2026
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes invisible oneOf/union/anyOf (and media type) toggle buttons in dark mode: text was white on white because fallbacks used
#fffbackground and#000color while the theme set a global light text color.Changes
src/TypeStyles.js: For.union-toggle,.one-of-toggle,.any-of-toggle, and.media-toggle, fallbacks changed from#fff/#000totransparent/inheritso they inherit from the theme. Activated state (#cddc39background,#000text) unchanged.test/api-type-document.test.js: New test ensuring union toggle buttons do not use hardcoded white background (rgb(255, 255, 255)).demo/index.html: Added "Dark mode" toggle (bottom-right) to verify the fix; preference stored inlocalStorage.Verification
npm testpasses (549 passed)transparent/inheritfallbacksRelated
Fix:
Button to enable dark mode in demo:
