Fix incorrect record form single url no loading#837
Open
shinyichen wants to merge 2 commits intoadsabs:masterfrom
Open
Fix incorrect record form single url no loading#837shinyichen wants to merge 2 commits intoadsabs:masterfrom
shinyichen wants to merge 2 commits intoadsabs:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #837 +/- ##
========================================
- Coverage 62.5% 62.4% -0.0%
========================================
Files 317 316 -1
Lines 36576 36512 -64
Branches 1673 1663 -10
========================================
- Hits 22827 22769 -58
+ Misses 13709 13703 -6
Partials 40 40
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update how we get a record's esource (urls) in incorrect record form, so that all urls can be loaded.
Previous we were using link_gateway page and parse urls in the html page. This was a problem when a record has only one url, which was instead redirected to that url instead. We were not able to parse the single url.
The screenshots show that records with single url and multiple urls are loaded.
2013admf.book.....D

2022AAS...24034906L
