Fix extract_classifications_pipeline empty string bug#219
Merged
Thomas-S-Allen merged 1 commit intoadsabs:masterfrom Jan 2, 2026
Merged
Fix extract_classifications_pipeline empty string bug#219Thomas-S-Allen merged 1 commit intoadsabs:masterfrom
Thomas-S-Allen merged 1 commit intoadsabs:masterfrom
Conversation
tjacovich
reviewed
Jan 2, 2026
Contributor
tjacovich
left a comment
tjacovich
left a comment
There was a problem hiding this comment.
@Thomas-S-Allen How does this line behave if no elements exist? Is db_classifications just []?
Contributor
Author
|
Yes, if there are no elements, db_classifications will just be [], and be caught by the current logic. |
tjacovich
approved these changes
Jan 2, 2026
tjacovich
added a commit
that referenced
this pull request
Feb 19, 2026
* adding lockfile scripts to long tasks (#213) * adding aws to requirements (#214) * adding aws to requirements * changing aws version * changing aws version 2 * changing aws version 3 * Added user-defined fields for scix id generation (#212) * Added user-defined fields for scix id generation * updated test cases * new version of scixpipelineutils * updating test scixids * updating test scixids * updating test scixids #3 * modified test cases to have at least title in bib_data * Update requirements.txt Co-authored-by: Taylor Jacovich <tjacovich@cfa.harvard.edu> --------- Co-authored-by: Taylor Jacovich <tjacovich@cfa.harvard.edu> * Update update_record to call async task for boost_mesage. Add queue for receiving augment processes. (#215) * Update update_record to call async task for boost_mesage. Add queue for receiving augment processes. * Broke boost call out of update storage to remove circular import. * removed circular import. * Fix args in task_boost_request. * Add awscli back to requirements.txt Added awscli version 1.27.60 to requirements. * Added support for pub_abbrev from import (#217) * Fix extract_classifications_pipeline empty string bug (#219) * Adding has_bib_data label (#216) * Adding has_bib_data label * Adding has_bib_data label * removing comment * removing unnecessary check * Rewrite task_update_record so that calls to task_boost_request is cal… (#220) * Rewrite task_update_record so that calls to task_boost_request is called for individual records when the message is a list type. * Add IGNORED_BOOST_PAYLOAD_TYPES to config. * upgrading scixpipelineutils requirement * Cleared out all classifier code. * update scix ids (#223) --------- Co-authored-by: Fernanda <femalves@users.noreply.github.com> Co-authored-by: mugdhapolimera <35502000+mugdhapolimera@users.noreply.github.com> Co-authored-by: Kelly Lockhart <2926089+kelockhart@users.noreply.github.com> Co-authored-by: Thomas S. Allen <tom.sco@gmail.com> Co-authored-by: Mugdha Polimera <mugdhapolimera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use list comprehension to remove empty strings from list of classifications