Skip to content

Update update_record to call async task for boost_mesage. Add queue for receiving augment processes.#215

Merged
tjacovich merged 4 commits intoadsabs:masterfrom
tjacovich:add-augment-records-queue
Dec 9, 2025
Merged

Update update_record to call async task for boost_mesage. Add queue for receiving augment processes.#215
tjacovich merged 4 commits intoadsabs:masterfrom
tjacovich:add-augment-records-queue

Conversation

@tjacovich
Copy link
Copy Markdown
Contributor

No description provided.

@tjacovich tjacovich marked this pull request as draft December 9, 2025 14:55
@tjacovich
Copy link
Copy Markdown
Contributor Author

@mugdhapolimera and @Thomas-S-Allen We are going to be transitioning all the augment processes to use the queue augment-record instead of update-record. It should be straightforward to modify the config.py files for the Boost and Classifier pipelines such that

OUTPUT_TASKNAME = "adsmp.tasks.task_update_record"

becomes

OUTPUT_TASKNAME = "adsmp.tasks.task_augment_record"

@tjacovich tjacovich marked this pull request as ready for review December 9, 2025 16:29
@seasidesparrow
Copy link
Copy Markdown
Member

@tjacovich Just a question: do you want to keep the machinery to update these via the update-records queue (in task_update_record) as well as in tasks_augment_record? I don't see the clauses removed from the former task

@tjacovich
Copy link
Copy Markdown
Contributor Author

@tjacovich Just a question: do you want to keep the machinery to update these via the update-records queue (in task_update_record) as well as in tasks_augment_record? I don't see the clauses removed from the former task

I would like to, at least in the short term so we don't end up with a bunch of lost augments in the event a version of the code that still uses update_record is deployed. I think once we are stable with this new system I will remove that backwards compatibility.

@tjacovich
Copy link
Copy Markdown
Contributor Author

We also need to add

OUTPUT_QUEUE = "augment-record"
FORWARD_MSG_DICT = [ \
    {'OUTPUT_PIPELINE': 'default', \
    'OUTPUT_CELERY_BROKER': OUTPUT_CELERY_BROKER,\
     'OUTPUT_QUEUE' : OUTPUT_QUEUE, \
    'OUTPUT_TASKNAME': OUTPUT_TASKNAME}, \
    ]

To the local_config.py for all the augmentation pipelines. This allows the messages to be forwarded to queues other than update-record.

@tjacovich tjacovich merged commit a9c8519 into adsabs:master Dec 9, 2025
2 checks passed
tjacovich added a commit that referenced this pull request Dec 9, 2025
…or receiving augment processes. (#215)

* Update update_record to call async task for boost_mesage. Add queue for receiving augment processes.

* Broke boost call out of update storage to remove circular import.

* removed circular import.

* Fix args in task_boost_request.
tjacovich added a commit that referenced this pull request Feb 19, 2026
* adding lockfile scripts to long tasks (#213)

* adding aws to requirements (#214)

* adding aws to requirements

* changing aws version

* changing aws version 2

* changing aws version 3

* Added user-defined fields for scix id generation (#212)

* Added user-defined fields for scix id generation

* updated test cases

* new version of scixpipelineutils

* updating test scixids

* updating test scixids

* updating test scixids #3

* modified test cases to have at least title in bib_data

* Update requirements.txt

Co-authored-by: Taylor Jacovich <tjacovich@cfa.harvard.edu>

---------

Co-authored-by: Taylor Jacovich <tjacovich@cfa.harvard.edu>

* Update update_record to call async task for boost_mesage. Add queue for receiving augment processes. (#215)

* Update update_record to call async task for boost_mesage. Add queue for receiving augment processes.

* Broke boost call out of update storage to remove circular import.

* removed circular import.

* Fix args in task_boost_request.

* Add awscli back to requirements.txt

Added awscli version 1.27.60 to requirements.

* Added support for pub_abbrev from import (#217)

* Fix extract_classifications_pipeline empty string bug (#219)

* Adding has_bib_data label (#216)

* Adding has_bib_data label

* Adding has_bib_data label

* removing comment

* removing unnecessary check

* Rewrite task_update_record so that calls to task_boost_request is cal… (#220)

* Rewrite task_update_record so that calls to task_boost_request is called for individual records when the message is a list type.

* Add IGNORED_BOOST_PAYLOAD_TYPES to config.

* upgrading scixpipelineutils requirement

* Cleared out all classifier code.

* update scix ids (#223)

---------

Co-authored-by: Fernanda <femalves@users.noreply.github.com>
Co-authored-by: mugdhapolimera <35502000+mugdhapolimera@users.noreply.github.com>
Co-authored-by: Kelly Lockhart <2926089+kelockhart@users.noreply.github.com>
Co-authored-by: Thomas S. Allen <tom.sco@gmail.com>
Co-authored-by: Mugdha Polimera <mugdhapolimera@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants