Draft
Conversation
|
There is a bug with this change whereby the actual target image you are setting the transform for gets cut off at the bottom (IE, it seems like this code change makes it get the wrong height for the image you are attempting to apply perspective transform to). Does not happen with master. |
Author
|
@mjgerace I tried to reproduce that, but couldn't... do you have a repro case I could take a look at? |
|
@akx I think the issue I found revolves around how you scale - you just use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR might seem big, but the commits and changes themselves are granular and self-contained.
It also enables ESlint to catch more possible bugs and makes typing a little stricter.
The end result is happily also a smaller bundle (3339 bytes -> 2980 bytes).