feat: show save button directly when editing configs#732
feat: show save button directly when editing configs#732usman-khalid wants to merge 1 commit intoadobe:mainfrom
Conversation
|
This is not the UX or design we would want for this. We will also be changing this slightly with @hannessolo's sheet collab PR. In the future, please raise an issue for discussion before implementing UX PRs. With every human on earth having different UX and design preferences, we will not be able to keep up with PRs to satisfy someone's personal preferences. It would also be good to get some community involvement in sharing ideas either in Discord or Slack and see how it resonates with others. This is why we keep UX consistent as possible across each view given the constraints we have. It keeps opinions out of decisions and it keeps documentation requirements less. A title bar looks like a title bar like a titlebar. When someone sees a paper plane, they should have a general idea of what it does based on other experiences across DA. This isn't about saving a click on one view, this is about creating a consistent experience across all of DA. Other rando thoughts
|
This is for an existing issue — #704. Feel free to close this PR if it's not in line with expected behaviour. |
|
@usman-khalid thanks for the reminder. I disagree with myself from time to time. :-) If you want to ship this, I would simply fill the existing blue button with the word "Save" instead of everything else. There's work to do on the cloud regarding current state, but it requires more consideration since we want to let authors know if something has changed while they have the sheet open. My loose idea is:
We can super gold plate-y with the above:
I would avoid most of these and simply pop a modal and offer to refresh or ignore. I do still think we wait for @hannessolo's collab PR so we get a sense of how config is impacted. |
03ef744 to
3d00b70
Compare
auniverseaway
left a comment
There was a problem hiding this comment.
The user experience seems perfect. We need to move a few of the bits around, but otherwise looks really good.
8abc506 to
9b88bb5
Compare
Summary
da-titleaction behavior by context: hides actions for docs under/.da/and allows save only for config and sheet viewsOther changes:
Related Issue
Fixes #704
How Has This Been Tested?
Tested on locally and on https://i704--da-live--usman-khalid.aem.page
Screenshots (if appropriate):
Types of changes
Checklist: