Skip to content

feat: show save button directly when editing configs#732

Open
usman-khalid wants to merge 1 commit intoadobe:mainfrom
usman-khalid:i704
Open

feat: show save button directly when editing configs#732
usman-khalid wants to merge 1 commit intoadobe:mainfrom
usman-khalid:i704

Conversation

@usman-khalid
Copy link
Contributor

@usman-khalid usman-khalid commented Jan 26, 2026

Summary

  • Refines da-title action behavior by context: hides actions for docs under /.da/ and allows save only for config and sheet views
  • Adds config staleness detection with polling and a modal prompt when remote config changes are detected during editing. User can choose to ignore or refresh

Other changes:

  • Updates the buttons in the component to have a pointer cursor to indicate they're clickable

Related Issue

Fixes #704

How Has This Been Tested?

Tested on locally and on https://i704--da-live--usman-khalid.aem.page

Screenshots (if appropriate):

image image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync
Copy link

aem-code-sync bot commented Jan 26, 2026

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@auniverseaway
Copy link
Member

This is not the UX or design we would want for this. We will also be changing this slightly with @hannessolo's sheet collab PR.

In the future, please raise an issue for discussion before implementing UX PRs. With every human on earth having different UX and design preferences, we will not be able to keep up with PRs to satisfy someone's personal preferences. It would also be good to get some community involvement in sharing ideas either in Discord or Slack and see how it resonates with others.

This is why we keep UX consistent as possible across each view given the constraints we have. It keeps opinions out of decisions and it keeps documentation requirements less. A title bar looks like a title bar like a titlebar. When someone sees a paper plane, they should have a general idea of what it does based on other experiences across DA. This isn't about saving a click on one view, this is about creating a consistent experience across all of DA.

Other rando thoughts

  1. The send animation should happen in a circle, it should not arbitrarily turn into a pill just for one view.
  2. There should be a prominent blue button (any shape) for the most important action on a given view and no more. This aligns with Spectrum guidelines.

@usman-khalid
Copy link
Contributor Author

This is not the UX or design we would want for this. We will also be changing this slightly with @hannessolo's sheet collab PR.

In the future, please raise an issue for discussion before implementing UX PRs. With every human on earth having different UX and design preferences, we will not be able to keep up with PRs to satisfy someone's personal preferences. It would also be good to get some community involvement in sharing ideas either in Discord or Slack and see how it resonates with others.

This is why we keep UX consistent as possible across each view given the constraints we have. It keeps opinions out of decisions and it keeps documentation requirements less. A title bar looks like a title bar like a titlebar. When someone sees a paper plane, they should have a general idea of what it does based on other experiences across DA. This isn't about saving a click on one view, this is about creating a consistent experience across all of DA.

Other rando thoughts

  1. The send animation should happen in a circle, it should not arbitrarily turn into a pill just for one view.
  2. There should be a prominent blue button (any shape) for the most important action on a given view and no more. This aligns with Spectrum guidelines.

This is for an existing issue — #704. Feel free to close this PR if it's not in line with expected behaviour.

@auniverseaway
Copy link
Member

@usman-khalid thanks for the reminder. I disagree with myself from time to time. :-)

If you want to ship this, I would simply fill the existing blue button with the word "Save" instead of everything else. There's work to do on the cloud regarding current state, but it requires more consideration since we want to let authors know if something has changed while they have the sheet open. My loose idea is:

  1. Upon open, cache the current sheet.
  2. Poll every two minutes to see if sheet has changed.
  3. If changed, warn the author.

We can super gold plate-y with the above:

  1. Offer to refresh
  2. Offer to compare
  3. Offer to stash changes

I would avoid most of these and simply pop a modal and offer to refresh or ignore. I do still think we wait for @hannessolo's collab PR so we get a sense of how config is impacted.

@usman-khalid usman-khalid force-pushed the i704 branch 3 times, most recently from 03ef744 to 3d00b70 Compare March 3, 2026 03:03
Copy link
Member

@auniverseaway auniverseaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user experience seems perfect. We need to move a few of the bits around, but otherwise looks really good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[config] da-title web component should show save

2 participants