Conversation
|
Tests/lint will pass once dependency adobe/da-tools#2 is merged and updated here. |
|
@hannessolo I don't see any unit tests for the new code in shareddoc.js? Just changes to make the existing tests work again. |
|
@bosschaert you're right, I initially had some tests for the json->yjs conversion but those live in the shared library now, and I neglected the tests for the shared doc. Added some now. I think the cases I covered should be enough but let me know if you find something that you think would also be good to cover. |
|
|
||
| function getDocType(docName) { | ||
| if (docName.endsWith('.json')) return 'json'; | ||
| if (docName.endsWith('.html')) return 'html'; |
There was a problem hiding this comment.
I guess this line does nothing because you'll return html regardless 😄
There was a problem hiding this comment.
True... I somehow didn't like not covering the html case explicitly too (for readability) but now that I think about it again return 'html' also makes it pretty clear that the other case to json is html even without the if... hmm
bosschaert
left a comment
bosschaert
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the tests!
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
4 participants
Add support for collab on sheets