Construct argument changed to reference#35
Conversation
I was getting an Undefined Variable error each time adLDAP was loaded, appears to be as the $options array is only created in the constructor declaration, and isn't being returned beyond the function scope. Not sure if $options should be declared at the top of the class to keep everything tidy (would appreciate clarification) but PHP seems quite happy to muddle through with &$options as is.
Contributor
|
Could you give more information about the error you were getting? Because it doesn't seem like this is the best way to solve it. Why would
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an Undefined Variable error each time adLDAP was loaded, appears to be as the $options array is only created in the constructor declaration, and isn't being returned beyond the function scope. Not sure if $options should be declared at the top of the class to keep everything tidy (would appreciate clarification) but PHP seems quite happy to muddle through with &$options as is.