Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Allow different versions of the json gem#10

Open
kaspernj wants to merge 1 commit intoadamcooke:masterfrom
kaspernj:kaspernj/allow-different-json-gem-versions
Open

Allow different versions of the json gem#10
kaspernj wants to merge 1 commit intoadamcooke:masterfrom
kaspernj:kaspernj/allow-different-json-gem-versions

Conversation

@kaspernj
Copy link
Copy Markdown

@kaspernj kaspernj commented Oct 1, 2017

Sometimes a project will be locked on a different JSON version, which makes it unable to bundle json-vat. This fixes that problem by allowing all versions above 1.7.0.

@jarthod
Copy link
Copy Markdown

jarthod commented Aug 19, 2018

This is indeed an issue, but it should be changed in the gemspec file, not in the Gemfile as the gemspec will be the one used by bundler to resolve dependencies when using the gem.

@jarthod
Copy link
Copy Markdown

jarthod commented Mar 19, 2020

The Gemfile fix is in #14 so this MR should be closed in favor of #14 IMO.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants