Skip to content

Upgrade to Node 24 with shared test workflow#21

Merged
johnrb2 merged 2 commits intomasterfrom
chore/upgrade-node-24
Apr 8, 2026
Merged

Upgrade to Node 24 with shared test workflow#21
johnrb2 merged 2 commits intomasterfrom
chore/upgrade-node-24

Conversation

@johnrb2
Copy link
Copy Markdown

@johnrb2 johnrb2 commented Apr 7, 2026

Description of the change

Summary

  • Upgrade Node.js test matrix to [20.x, 24.x] (drop EOL versions)
  • Migrate test workflow to shared reusable workflow from activeprospect/github-action-workflows
  • Add .nvmrc (Node 24) for local dev consistency
  • Add engines field to package.json (>=20)

Part of the Node 24 upgrade effort (sc-107377).

Note: This PR supersedes the test.yml changes in #20 (actions version pinning by lolaruAP). That PR's changes to other workflow files (e.g. codeql-analysis.yml) remain independently useful.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • UI Change Only
  • Chore
  • Configuration change
  • Technical Debt
  • Documentation

Related tickets

https://app.shortcut.com/activeprospect/story/107377

Checklists

Development and Testing

  • Lint rules pass locally.
  • The code changed/added as part of this pull request has been covered with tests, or this PR does not alter production code.
  • All tests related to the changed code pass in development, or tests are not applicable.

Code Review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • At least two engineers have been added as "Reviewers" on the pull request.
  • Changes have been reviewed by at least two other engineers who did not write the code.
  • This branch has been rebased off master to be current.

Tracking

  • Issue from Shortcut/Jira has a link to this pull request.
  • This PR has a link to the issue in Shortcut.

QA

  • This branch has been deployed to staging and tested.

Migrate test.yml to use shared reusable workflow from
activeprospect/github-action-workflows. Add .nvmrc and engines field.
@johnrb2 johnrb2 force-pushed the chore/upgrade-node-24 branch from 03c1c1e to 351c357 Compare April 8, 2026 17:26
Copy link
Copy Markdown

@josevsalina josevsalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node 24 upgrade — CI green, changes limited to expected scope (.nvmrc, test workflow, package.json engines). LGTM.

@johnrb2 johnrb2 merged commit aef64d4 into master Apr 8, 2026
2 checks passed
@johnrb2 johnrb2 deleted the chore/upgrade-node-24 branch April 8, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants