Upgrade to Node 24 with shared test workflow#21
Merged
Conversation
Migrate test.yml to use shared reusable workflow from activeprospect/github-action-workflows. Add .nvmrc and engines field.
77b6efa to
e1aadfa
Compare
Made-with: Cursor
03c1c1e to
351c357
Compare
josevsalina
approved these changes
Apr 8, 2026
josevsalina
left a comment
There was a problem hiding this comment.
Node 24 upgrade — CI green, changes limited to expected scope (.nvmrc, test workflow, package.json engines). LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Summary
activeprospect/github-action-workflows.nvmrc(Node 24) for local dev consistencyenginesfield topackage.json(>=20)Part of the Node 24 upgrade effort (sc-107377).
Type of change
Related tickets
https://app.shortcut.com/activeprospect/story/107377
Checklists
Development and Testing
Code Review
Tracking
QA