Open
Conversation
Reverted the transaction/truncate-based test isolation approach to maintain the original test structure while preserving the configurable database connection parameters. Changes: - Restored original test setup/teardown structure - Kept DB_HOST, DB_USER, DB_PASS, DB_NAME environment variable support - Removed static connections and table truncation logic - Tests continue to use DROP/CREATE tables approach All 137 tests passing with configurable database credentials. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Renamed phpunit.xml to phpunit.xml.dist as a template - Set default DB_PASS to empty string in template - Added phpunit.xml to .gitignore for local customization - Users can copy phpunit.xml.dist to phpunit.xml and set their own credentials This prevents accidentally committing database credentials while allowing developers to customize their local test configuration. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just to check everything, don't merge yet.