A date_exported to sketch files - resolves #593#604
Merged
Conversation
Pete-Y-CS
force-pushed
the
add-export-date
branch
from
4523119 to
37d3703
Compare
Sparrow0hawk
requested changes
Jun 2, 2025
Contributor
Sparrow0hawk
left a comment
Sparrow0hawk
left a comment
There was a problem hiding this comment.
Want your brief thoughts on tweak to proposed change but once covered off this will be good to merge.
src/lib/common/files.ts
Outdated
| } | ||
| copy.authority = authority; | ||
| copy.origin = "atip-v2"; | ||
| copy.sketch_exported = new Date().toDateString(); |
Contributor
There was a problem hiding this comment.
I think for dates/datetimes probably best to try and go with ISO 8601 format to help with machine readability as well as human. Which I think you can achieve with Date.prototype.toISOString.
Suggested change
| copy.sketch_exported = new Date().toDateString(); | |
| copy.sketch_exported = new Date().toISOString(); |
Collaborator
Author
There was a problem hiding this comment.
makes complete sense - I tried a couple and went for increased human readability, but given it's going into the data platform better to go for the more easily processed format
Sparrow0hawk
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.