chore: Remove revert strings from tests profile#1375
chore: Remove revert strings from tests profile#1375
Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 427a79f390
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| src = "contracts" | ||
| out = "out" | ||
| test = "test/evm/foundry" | ||
| test = "test/evm/foundry/local" |
There was a problem hiding this comment.
Keep fork tests in the default compile surface
Changing profile.default.test to test/evm/foundry/local means the only Foundry commands we run in CI now ignore test/evm/foundry/fork/*: upload-evm-artifacts builds with the default profile in .github/workflows/pr.yml:57-62, and test-evm runs yarn test-evm-foundry in .github/workflows/pr.yml:216-217, which now resolves to plain forge test. As a result, syntax/import/type errors in fork tests can merge unnoticed even though this commit edits files in that suite.
Useful? React with 👍 / 👎.
No description provided.