Conversation
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
fusmanii
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
* add scripts/verifyBytecodeEraVM.sh Signed-off-by: Ihor Farion <ihor@umaproject.org> * correct comments Signed-off-by: Ihor Farion <ihor@umaproject.org> --------- Signed-off-by: Ihor Farion <ihor@umaproject.org>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
foundry.toml
Outdated
| revert_strings = "strip" | ||
| fs_permissions = [{ access = "read-write", path = "./" }] | ||
| use_literal_content = true | ||
| metadata = "none" |
There was a problem hiding this comment.
I think settings are different? https://www.getfoundry.sh/guides/deterministic-deployments-using-create2#configuring-for-determinism
Also, I'm hesitant if we really want to add this as a global default. Let's discuss in the meet tomorrow. Now that we know that whitespace affects the things and that we have a CI check for formatting, our deployments should become more deterministic overtime even without this setting
There was a problem hiding this comment.
Disable metadata hash for deterministic bytecode
looks like they recommend to disable for deterministic bytecode
There was a problem hiding this comment.
only disabling metadata in eraVM 60a6f78
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
Signed-off-by: Faisal Usmani <faisal.of.usmani@gmail.com>
grasphoper
left a comment
grasphoper
left a comment
There was a problem hiding this comment.
LGTM, let's merge after we execute the multisig right
2 participants
No description provided.