Conversation
|
The Travis build shows no log at all, so I'm a bit confused as to why this failed. It builds on macOS 10.12 locally, FWIW. |
|
FWIW, Fedora would like to have this too. https://bugzilla.redhat.com/show_bug.cgi?id=1449130 |
|
The Travis build log shows up fine for me. |
|
I haven’t looked at this since I filed the initial PR here so I can’t vouch for how compliant it is with the latest releases. I’ll try and glance over the code again over in the next couple days. |
|
Still seems to build & link fine locally against |
|
Note that travis uses a very old ubuntu with a very old libidn2 which doesn't contain the function used in this patch. Also in the linking part I see that libidn is linked in addition to libidn2 which most likely is the failure reason. |
libidn2 is stable now, and slowly being adopted more widely. Here's a patch to add support for it as desired.
Some projects are simply dropping
libidn1.x support likecurlandwget, but a minimally-invasive change by logic would seem to have a better chance of not being rejected. Tested with./configure --with-libidn2 --without-libidnand it built fine.Please feel free to sanity check this, I do not claim to do C well, and stupidity is not above me 😄.