Refactor number validation logic and fix typos#1596
Closed
RafsanNeloy wants to merge 2 commits intoaces:masterfrom
Closed
Refactor number validation logic and fix typos#1596RafsanNeloy wants to merge 2 commits intoaces:masterfrom
RafsanNeloy wants to merge 2 commits intoaces:masterfrom
Conversation
Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
… message Signed-off-by: rafsanneloy <rafsanneloy@gmail.com>
Member
|
Please rebase or re-submit as this PR already contains code changes that were merged in your previous pull request, #1595 |
Contributor
Author
|
Sorry my mistake.. Fixing it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In number validation logic
elsif (number = Integer(value) rescue Float(value) rescue nil)andelsif (number = (Integer(value) rescue Float(value) rescue nil))both are right but i think the second one is cleaner and clearer to understand perfectly.Also the maximum value typo fixed in this PR