Open
Conversation
…m ax. Also improved Runnable.is_scan(), made Runnable.extract_beam_function() work for multi-shot runs that are not a scan and edited some doc strings.
kyrsjo
reviewed
Nov 11, 2025
abel/classes/runnable.py
Outdated
|
|
||
| # perform optimization | ||
| from ax import optimize as bayes_opt | ||
| from ax.service.managed_loop import optimize as bayes_opt |
Collaborator
There was a problem hiding this comment.
Where did this change?
Maybe enforce ax version number in project def ?
Collaborator
Author
There was a problem hiding this comment.
Yes, we should indeed restrict this to e.g. > 1.0.0 and <=1.2.1.
Collaborator
Author
|
For the record, the last version that had |
Collaborator
|
OK, so postpone for now until the correct way is found? |
Collaborator
Author
Yes, or the method is probably the same one as this one: https://pypi.org/project/ax-platform/1.2.1/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug in
Runnable.optimize()by updating the import commandfrom ax import optimize as bayes_opttofrom ax.service.managed_loop import optimize as bayes_opt.Also improved
Runnable.is_scan(), madeRunnable.extract_beam_function()work for multi-shot runs that are not a scan and edited some doc strings.