feat(compat): set a2a-version header to 1.0.0#764
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the client's communication by automatically including a protocol version header in all requests. This change standardizes how the client identifies its protocol version to services, which is crucial for maintaining compatibility and enabling future API evolution. It ensures that both HTTPX and gRPC clients consistently send this version information, improving robustness and clarity in client-server interactions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the X-A2A-Version header to outgoing requests, which is a good step for protocol compatibility. The implementation looks mostly correct, with changes across HTTP and gRPC transports. I've left a couple of suggestions: one to improve code clarity by removing a redundant operation in the ClientFactory, and another to correct a type hint in the gRPC transport to align with the new logic and repository style guide.
a872513 to
a680105
Compare
a680105 to
77c1c99
Compare
77c1c99 to
b8da2ed
Compare
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.fix:which represents bug fixes, and correlates to a SemVer patch.feat:represents a new feature, and correlates to a SemVer minor.feat!:, orfix!:,refactor!:, etc., which represent a breaking change (indicated by the!) and will result in a SemVer major.bash scripts/format.shfrom the repository root to format)