🎨 Palette: Fix TableLayout Column Alignment & Spanning#63
🎨 Palette: Fix TableLayout Column Alignment & Spanning#63manupawickramasinghe wants to merge 1 commit intomainfrom
Conversation
- Grouped `switch1`, `switch2`, and `switchRTSP` into a spanning `<LinearLayout>` to prevent them from unintentionally forcing a 3rd table column, which broke the UI alignment. - Added `android:layout_span="2"` to the divider `<View>` to ensure it acts as a proper full-width separator across the 2-column layout. - Removed the inaccessible `android:minWidth="10dp"` constraint on the `buttonKill` (STOP button) to ensure it can utilize proper accessible minimum touch target defaults. - Added spacing between the grouped switches. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎨 Palette: Fix TableLayout Column Alignment & Spanning
💡 What: Restructured the 3 Switches (Preview, Stream, RTSP) by wrapping them in a
<LinearLayout>withandroid:layout_span="2". Addedandroid:layout_span="2"to the decorative divider line. Removedandroid:minWidth="10dp"from the STOP button.🎯 Why: The 3 switches were placed directly in a
<TableRow>, inadvertently forcing the parent<TableLayout>into a 3-column structure. Since all other rows only had 2 columns, this broke the alignment of the labels and spinners below. Grouping them inside a spanning layout preserves the intended 2-column structure and aligns the UI neatly. Additionally, the divider was only spanning column 0; it now correctly spans both columns. Finally, the artificial 10dp minimum width on the STOP button restricted accessible touch target sizes.♿ Accessibility: Removing
minWidth="10dp"from theButtonallows it to reach standard minimum touch target sizes. Grouping the switches visually and logically improves the predictability of the UI for users.PR created automatically by Jules for task 6271716387024429792 started by @manupawickramasinghe