Open
Conversation
Collaborator
|
Закомітив node_modules? :( |
Owner
Author
|
Виправив наче, але я ще в процесі розробки) |
VitaliiHurin
requested changes
Feb 9, 2020
homework-08/src/req-pr-nt.js
Outdated
Comment on lines
+58
to
+63
| for (let count = 1; count < 30; count += 1) { | ||
| setTimeout(() => { | ||
| mainPoint(); | ||
| }, 100 * 2 ** count); | ||
| break; | ||
| } |
Collaborator
There was a problem hiding this comment.
Що це за такий спосіб дивний? :)
Воно ж все одно буде щоразу з 1 стартувати.
Comment on lines
+33
to
+50
| async function mainLimit() { | ||
| try { | ||
| const data = await request.post(optionsLimit); | ||
| console.log('Limit:', data); | ||
| } catch (error) { | ||
| console.log(error); | ||
| } | ||
| } | ||
|
|
||
| async function mainMetrics() { | ||
| try { | ||
| const data = await request(optionsMetrics); | ||
| console.log('Metrics:', data); | ||
| } catch (error) { | ||
| console.log(error); | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Чому тут нема ретраїв?
homework-08/src/choice.js
Outdated
Comment on lines
+3
to
+4
| const httpCL = require('./httpClient'); | ||
| const rpn = require('./req-pr-nt'); |
Collaborator
There was a problem hiding this comment.
Різна стилістика написання назв файлів.
І взагалі, чому економити букви в назві файла? :)
homework-08/server/controller.js
Outdated
| headers: { authorization }, | ||
| } = req; | ||
|
|
||
| if (authorization !== 'Basic WWV2aGVuOjEyMzQ1') { |
Collaborator
There was a problem hiding this comment.
Краще Basic Auth реалізувати не так з явною перевіркою напряму.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.