Removed check for neg. address and changed offset calculation in mmio.cc, as it limits ZYNQ-7 boards#1525
Open
DirkStober wants to merge 1 commit intoXilinx:image_v3.1.3from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for negative addresses when allocating the MMIO disables half the address space of the ZYNQ-7000 boards, as all 32-bit are required to map the higher half (for example MAXI_GP1) (off_t is a 32bit integer for arm32).
In addition, the check for negative base addresses still leaves plenty of illegal addresses for the Zynq US+, as the maximum valid address is 40 bit wide.
I would suggest removing the negative base address check and changing the calculation of the virt_off to use a bitwise operation to avoid any overflows.
Signed-off-by: Dirk Stober dirk.stober@tum.de