Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=====================================
Coverage 80.5% 80.6%
=====================================
Files 13 13
Lines 716 717 +1
=====================================
+ Hits 577 578 +1
Misses 115 115
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
XSAM
reviewed
Jun 16, 2023
Owner
XSAM
left a comment
There was a problem hiding this comment.
Hi @LeonPev, Thanks for the PR.
Could you please attach examples and screenshots that shows SQL comment in spans?
Please also change ExecContext and PrepareContext for consistency. And, update tests and CHANGELOG.md to reflect this change.
devopsmetis
approved these changes
Jun 20, 2023
Owner
|
Hi @LeonPev, do you still have an interest in implementing this? I can take this if you are not interested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added sqlcommenter output to the sql.conn.query span for compatibility with js and py packages that have similar behavior