fix: bump websockets minimum version to >=14#945
fix: bump websockets minimum version to >=14#945m1lestones wants to merge 1 commit intoXRPLF:mainfrom
Conversation
The websocket_base.py module uses `websockets.asyncio.client` and `ClientConnection`, which were introduced in websockets 14.0 as the new asyncio-native API replacing the deprecated legacy interface. The previous lower bound of >=11 allowed installing websockets versions that lack `websockets.asyncio`, causing ImportError at runtime. Closes XRPLF#867 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Closes #867
The
websocket_base.pymodule migrated towebsockets.asyncio.clientandClientConnection(the new asyncio-native API introduced in websockets 14.0) to eliminate deprecation warnings from the legacy interface. However, thepyproject.tomldependency lower bound was never updated to reflect this requirement.With
websockets = ">=11", users can install websockets 11–13 which lackwebsockets.asyncio, causing anImportErrorat runtime.Changes
websocketsminimum version from>=11to>=14inpyproject.tomlWhy >=14?
The
websockets.asynciosubpackage (includingClientConnection) was introduced in websockets 14.0. The websockets changelog confirms this is the version that added the new asyncio-native API thatwebsocket_base.pyalready uses.Test plan
import websockets.asyncio.clientworks with websockets >=14python -m pytest tests/unit/🤖 Generated with Claude Code