Enhancement of BuildRowNumberStatement

[ecosSystem]

BuildRowNumberStatement now respects filters, scopes and orderconditions. This is needed to calculate the correct pagenumber

[RobertvanderHulst]

Looks good Karl!

[ecosSystem]

Robert, it seems to me that a setfilter does not set _oTable:Serverfilter. _oTable:HasServerFilter is always empty. Filters seem to be implemented in skip(). Shouldn’t filters for better performance always be in the where-clauses ? Am I right with my assumption ? Karl Von: Robert van der Hulst ***@***.***> Gesendet: Montag, 16. März 2026 08:50 An: X-Sharp/XSharpPublic ***@***.***> Cc: Karl Wochele ***@***.***>; Author ***@***.***> Betreff: Re: [X-Sharp/XSharpPublic] Enhancement of BuildRowNumberStatement (PR #1849) [https://avatars.githubusercontent.com/u/14240939?s=20&v=4]RobertvanderHulst left a comment (X-Sharp/XSharpPublic#1849)<#1849 (comment)> Looks good Karl! — Reply to this email directly, view it on GitHub<#1849 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5LVZS6LCULI4ARX62WBUT4Q6W2BAVCNFSM6AAAAACWTAGSH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRVG4ZTIMRSGM>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[RobertvanderHulst]

Karl,
SetFilter() may use a code block with code that can only be evaluated at the workstation. That is why filters are evaluated in the Skip block. Filtering on the server should be faster of course. That is why I added the server filter.

[ecosSystem]

Ok, understood. Next thing I will examine is GoBottom() in a conditional order. This does not work as expected yet. Von: Robert van der Hulst ***@***.***> Gesendet: Montag, 16. März 2026 10:30 An: X-Sharp/XSharpPublic ***@***.***> Cc: Karl Wochele ***@***.***>; Author ***@***.***> Betreff: Re: [X-Sharp/XSharpPublic] Enhancement of BuildRowNumberStatement (PR #1849) [https://avatars.githubusercontent.com/u/14240939?s=20&v=4]RobertvanderHulst left a comment (X-Sharp/XSharpPublic#1849)<#1849 (comment)> Karl, SetFilter() may use a code block with code that can only be evaluated at the workstation. That is why filters are evaluated in the Skip block. Filtering on the server should be faster of course. That is why I added the server filter. — Reply to this email directly, view it on GitHub<#1849 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5LVZT7ALO5GBF77M2Y52D4Q7CSHAVCNFSM6AAAAACWTAGSH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRWGI4DIOJQGY>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[loaded02]

Hi,
looks like you removed method GetOrderKeyNo() from @thomasdvbern
Was this on purpose?

[ecosSystem]

Yes, it is now implemented with BuildRowNumberStatement Von: Moritz H ***@***.***> Gesendet: Montag, 16. März 2026 10:54 An: X-Sharp/XSharpPublic ***@***.***> Cc: Karl Wochele ***@***.***>; Author ***@***.***> Betreff: Re: [X-Sharp/XSharpPublic] Enhancement of BuildRowNumberStatement (PR #1849) [https://avatars.githubusercontent.com/u/6240405?s=20&v=4]loaded02 left a comment (X-Sharp/XSharpPublic#1849)<#1849 (comment)> Hi, looks like you removed method GetOrderKeyNo() from @thomasdvbern<https://github.com/thomasdvbern> Was this on purpose? — Reply to this email directly, view it on GitHub<#1849 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AK5LVZQGZYLDC6WFO5C4YST4Q7FM5AVCNFSM6AAAAACWTAGSH6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANRWGQ2DKMBQGU>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>