input method: make sure down edge is inside screen even the submitted coordinates aren't#2990
Merged
ammen99 merged 1 commit intoWayfireWM:masterfrom Mar 7, 2026
Merged
Conversation
… coordinates aren't
ammen99
approved these changes
Mar 7, 2026
Member
ammen99
left a comment
ammen99
left a comment
There was a problem hiding this comment.
LGTM, nice catch! I assume this happens very rarely, but the proposed solution makes sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed in patched minecraft (glfw/glfw#2130 (comment)) that the client submitted a point outside the screen, thus that even after flipping it is still too low.