Skip to content

Fix "vswitch" plugin: undesired 'last' direction#2984

Open
WShad wants to merge 3 commits intoWayfireWM:masterfrom
WShad:fix/vswitch_u
Open

Fix "vswitch" plugin: undesired 'last' direction#2984
WShad wants to merge 3 commits intoWayfireWM:masterfrom
WShad:fix/vswitch_u

Conversation

@WShad
Copy link

@WShad WShad commented Feb 24, 2026

Fixes wrong direction on "last" caused by changing workspace by external methods.
Example: switch workspace by activating window via wf-panel, as a result control_bindings_t knows nothing about this transition and remembers wrong "last direction".

@ammen99
Copy link
Member

ammen99 commented Mar 7, 2026

@WShad Thanks for looking into this issue! Is this the same as #1390 ?
If yes, I think an even better way of doing it will be to add a listener for the signal emitted when the current workspace changed. This way, we won't need to adapt any other plugins - simply vswitch will keep track of any workspace change and know how to revert that. Do you think this will work as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants