This repository was archived by the owner on Apr 19, 2023. It is now read-only.
Additional unit tests to improve test coverage.#2
Open
EmilGeorgiev wants to merge 1 commit intoVolumeFi:mainfrom
Open
Additional unit tests to improve test coverage.#2EmilGeorgiev wants to merge 1 commit intoVolumeFi:mainfrom
EmilGeorgiev wants to merge 1 commit intoVolumeFi:mainfrom
Conversation
EmilGeorgiev
commented
Dec 28, 2022
EmilGeorgiev
commented
- Added unit tests for "./client/chain_registry/cosmos_github_registry.go" by using library "github.com/migueleliasweb/go-github-mock/src/mock" to mock RPC requests. One minor change in the production code.
- Added additional test cases for the functions 'broadcastTx' and 'CheckTendermintError' in the file "./client/broadcast.go". No production code changed.
EmilGeorgiev
force-pushed
the
improve_test_coverage
branch
from
9f20690 to
125c7be
Compare
1. Added unit tests for "./client/chain_registry/cosmos_github_registry.go" by using library "github.com/migueleliasweb/go-github-mock/src/mock" to mock RPC requests. One minor change in the production code. 2. Added additional test cases for the functions broadcastTx and CheckTendermintError in the file "./client/broadcast.go". No production code changed.
EmilGeorgiev
force-pushed
the
improve_test_coverage
branch
from
125c7be to
d4e0062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.