Add some string comparision capabilities to TPixelFont#558
Open
Torwent wants to merge 1 commit intoVillavu:simba2000from
Open
Add some string comparision capabilities to TPixelFont#558Torwent wants to merge 1 commit intoVillavu:simba2000from
Torwent wants to merge 1 commit intoVillavu:simba2000from
Conversation
Contributor
Author
|
I also decided to make everything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be pretty straightforward but helps comparing/replacing characters with the
TPixelFontglyphs in mind.I wasn't sure what to use for the unique glyph signature and decided to go with a slightly modified @slackydev hashing function, feel free to pick something more suitable if this is to be merged.
I kind of wanted to also build what
String.Similarity()does into this but it seemed too crazy and I'm not sure if it's worth the trouble as it can just be chained with theTPixelFont.ReplaceSameGlyph()I added in this.I would like to ask however if there's a reason to not using the Chars ASCII value to index the glyphs?
I understand it would take a few more bytes but since there's only 255 characters max I don't really see it as a big deal and would make stuff like this much cheaper to do.