vmalertmanager: do not ignore tracing config, when to alertmanagerconfig CRs are collected#1984
Open
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Open
vmalertmanager: do not ignore tracing config, when to alertmanagerconfig CRs are collected#1984AndrewChubatiuk wants to merge 1 commit intomasterfrom
AndrewChubatiuk wants to merge 1 commit intomasterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
…fig CRs are collected
AndrewChubatiuk
force-pushed
the
vmalertmanager-fix-tracing-config
branch
from
1c54e4e to
49c70d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1983
Summary by cubic
Fixes
vmalertmanagerignoring tracing config when noVMAlertmanagerConfigCRs are collected. Tracing settings from theVMAlertmanagerresource are now applied even without discovered configs.VMAlertmanagerConfigobjects are found (fixes vmalertmanager: tracing configuration is ignored if VMAlertmanagerConfig is not used #1983).Written for commit 49c70d0. Summary will update on new commits.