Conversation
vrutkovs
reviewed
Mar 16, 2026
| } | ||
|
|
||
| return updatePVC(ctx, rclient, &existingObj, newObj, prevObj, owner) | ||
| func waitForPVCBound(ctx context.Context, rclient client.Client, nsn types.NamespacedName, generation int64) error { |
Collaborator
There was a problem hiding this comment.
Lets add unit tests for this function
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
4 issues found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/controller/operator/factory/reconcile/reconcile.go">
<violation number="1" location="internal/controller/operator/factory/reconcile/reconcile.go:27">
P1: The new PVC wait uses a hardcoded 5s timeout, so PVC binding can fail much earlier than the operator's configured readiness deadlines.</violation>
</file>
<file name="internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go">
<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go:124">
P1: `waitForPVCBound` is called with the StatefulSet name instead of the PVC name, so it polls a non-existent PVC and times out.</violation>
</file>
<file name="internal/controller/operator/factory/reconcile/pvc.go">
<violation number="1" location="internal/controller/operator/factory/reconcile/pvc.go:51">
P1: Terminating PVCs no longer short-circuit successfully; this unconditional wait turns the previous skip path into a reconcile error.</violation>
<violation number="2" location="internal/controller/operator/factory/reconcile/pvc.go:51">
P1: Waiting for PVCs to reach `Bound` here can block valid `WaitForFirstConsumer` claims before their Deployment is created.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go
Outdated
Show resolved
Hide resolved
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
wait-for-pvc-status
branch
from
83d01f0 to
d9fd316
Compare
Contributor
Author
Contributor
|
@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
3 issues found across 15 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="internal/controller/operator/factory/reconcile/deploy.go">
<violation number="1" location="internal/controller/operator/factory/reconcile/deploy.go:102">
P1: `ProgressTimeoutExceeded` is not the Deployment condition reason Kubernetes sets here; use `ProgressDeadlineExceeded` or rollout timeout failures will be missed.</violation>
</file>
<file name="internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go">
<violation number="1" location="internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go:127">
P1: This waits on a stale PVC generation, so a just-updated PVC can be treated as ready before the resize spec is observed.</violation>
</file>
<file name="internal/controller/operator/factory/k8stools/interceptors.go">
<violation number="1" location="internal/controller/operator/factory/k8stools/interceptors.go:82">
P2: This now calls `Status().Update` for StatefulSet, Deployment, and PVC too, but the fake client is not configured with status subresources for those types, so intercepted updates will fail in tests.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go
Outdated
Show resolved
Hide resolved
AndrewChubatiuk
force-pushed
the
wait-for-pvc-status
branch
5 times, most recently
from
f58e467 to
e137c63
Compare
AndrewChubatiuk
force-pushed
the
wait-for-pvc-status
branch
2 times, most recently
from
aec1218 to
e330290
Compare
vrutkovs
requested changes
Mar 19, 2026
| if !existingObj.CreationTimestamp.IsZero() { | ||
| size = existingObj.Spec.Resources.Requests[corev1.ResourceStorage] | ||
| } | ||
| if err = waitForPVCReady(ctx, rclient, nsn, size); err != nil { |
Collaborator
There was a problem hiding this comment.
We should be waiting for ready PVC only after DeletionTimestamp check? If VMCluster is being delete we don't need to wait for bound PVC
Contributor
Author
There was a problem hiding this comment.
there are two loops: one for creation/update, another one - waiting for PVC readiness. deletion may happen in each of these loops, that's why checking deletion timestamp in both, exiting without error and showing a warning. No further reconciliation is needed till user performs manual actions
internal/controller/operator/factory/reconcile/statefulset_pvc_expand.go
Show resolved
Hide resolved
AndrewChubatiuk
force-pushed
the
wait-for-pvc-status
branch
from
e330290 to
1dbeca6
Compare
Contributor
Author
|
@vrutkovs could you please take a look? |
vrutkovs
approved these changes
Mar 20, 2026
AndrewChubatiuk
added a commit
that referenced
this pull request
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1970
Summary by cubic
Wait for PVCs to be fully ready (Bound with requested capacity and not Resizing) before continuing reconcile and during StatefulSet PVC expansion. This pauses pod rollouts until storage is actually usable.
waitForPVCReadywith polling viaVM_PVC_WAIT_READY_INTERVALandVM_PVC_WAIT_READY_TIMEOUT; waits for requested capacity, PVC to be Bound, and not Resizing; skips if PVC is deleting.reconcile.Initnow takesBaseOperatorConf; addedVM_WAIT_READY_INTERVALfor VM CRs; renamed internals toAppWaitReadyTimeoutandPodWaitReadyInterval, env names unchanged).Written for commit 1dbeca6. Summary will update on new commits.