Fixing Sitecore.Mvc.Exceptions.CyclicRenderingException.#48
Open
Fixing Sitecore.Mvc.Exceptions.CyclicRenderingException.#48
Conversation
Sitecore uses the ToString method on the Renderer class to try and detect cyclic renderings. Since MiniProfilerRenderer wraps the implementing renderer, Sitecore is detecting a cyclic rendering scenario. This is currently breaking the Forms builder in Sitecore. To fix, I've overriden the ToString method on MiniProfilerRenderer and returning the ToString value of the inner renderer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sitecore uses the ToString method on the Renderer class to try and detect cyclic renderings. Since MiniProfilerRenderer wraps the implementing renderer, Sitecore is detecting a cyclic rendering scenario. This is currently breaking the Forms builder in Sitecore.
To fix, I've overriden the ToString method on MiniProfilerRenderer and returning the ToString value of the inner renderer.